From owner-freebsd-current@FreeBSD.ORG Tue Nov 22 17:59:20 2011 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DCD38106566C; Tue, 22 Nov 2011 17:59:20 +0000 (UTC) (envelope-from rmh.aybabtu@gmail.com) Received: from mail-iy0-f182.google.com (mail-iy0-f182.google.com [209.85.210.182]) by mx1.freebsd.org (Postfix) with ESMTP id 7EEB18FC08; Tue, 22 Nov 2011 17:59:20 +0000 (UTC) Received: by iakl21 with SMTP id l21so758172iak.13 for ; Tue, 22 Nov 2011 09:59:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=CqYJlEeVevEYv63b2oOGDu6p9ZBFvCC7qR3FjCJ9Rx4=; b=EpyR822OnRfFVI6wAveTRYDOEF1Stfjfv1psmsj17isDTTWgFA/cQeS4oWau9SQSib V8PyIXvsPPnriQPfGhKPC95Ou8wM6GMvJlRJKV+mNcZEvGjvhfHyLY6QW/7lVooOAA9J lyjvRh8DgjQMi3wm/7OXs8OfdLN22dgsh2SYo= MIME-Version: 1.0 Received: by 10.50.149.165 with SMTP id ub5mr23104261igb.23.1321984759696; Tue, 22 Nov 2011 09:59:19 -0800 (PST) Sender: rmh.aybabtu@gmail.com Received: by 10.42.222.200 with HTTP; Tue, 22 Nov 2011 09:59:19 -0800 (PST) In-Reply-To: <201111220824.07823.jhb@freebsd.org> References: <20111121092749.GD50300@deviant.kiev.zoral.com.ua> <201111220824.07823.jhb@freebsd.org> Date: Tue, 22 Nov 2011 18:59:19 +0100 X-Google-Sender-Auth: bd6J299HIomwO-QgrENhS4BJyUk Message-ID: From: Robert Millan To: John Baldwin Content-Type: text/plain; charset=UTF-8 X-Mailman-Approved-At: Tue, 22 Nov 2011 18:09:44 +0000 Cc: Kostik Belousov , Adrian Chadd , freebsd-current@freebsd.org, freebsd-arch@freebsd.org Subject: Re: [PATCH] Detect GNU/kFreeBSD in user-visible kernel headers X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Nov 2011 17:59:21 -0000 2011/11/22 John Baldwin : > Is __FreeBSD_version defined if __FreeBSD_kernel__ is defined on kFreeBSD? Not currently (except for kernel-space code), but if all the checks that use __FreeBSD_version are like the one you describe, I think it'd make sense. But we need to make sure that defining it wouldn't suddenly enable code that is intended for FreeBSD userland, like it happens with __FreeBSD__. It'd also have to be discussed on Debian mailing list. My first impression is that defining it could be useful in some situations. We just don't run into this kind of situation so often, so this possibility AFAIK has never been discussed. I had it in my TODO to bring it up. -- Robert Millan