From nobody Mon Feb 16 02:18:43 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fDmfX6WlZz6RvVD; Mon, 16 Feb 2026 02:18:44 +0000 (UTC) (envelope-from des@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R12" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fDmfX54BXz3xdT; Mon, 16 Feb 2026 02:18:44 +0000 (UTC) (envelope-from des@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771208324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u0B5+BSo14q2vID9Y4iDRd5Ns56Q6yb52saMNU1B+8M=; b=bN2+NyDXdjReSkKG3v2zob3EV49/3bXeua/+vtXzzlpzKZFM0XgfuEZIA/OouDpphEtw7S Nkx8HUqr0+tuZWW0BSKocC10DFI+r/gKL7FHcOmF1lVSVxG3eqPpDWyLnmtoVWbGXb0FCm eHg0u8/9TU+C9d3qMLPIXKolCutQhPV893ozENNgso02zI/S/Bc7YSweHV6jxjGuaum+l1 8zkQsaHk+MBC/2ryvhprc21JknHI+XtEfk+TX+fq+uCqH6WIhTxA2Z9aPDK2MOTCS6XI0r S5Jqe5Vw/MXHoB95Xhjj9JV3FBqI51xIXKNiRGcoW4niwZ3daJrS3/bkd71dyA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1771208324; a=rsa-sha256; cv=none; b=RCRsxHbmxG6hZfXlp0Prc80+hNQctTYKSmmaTUzb5USl+aBZ6oaFWdZMD9gA9Rhfjgt6RO LqNJ3VsJ3fNX2a3o2ZgoDnNplSnfAVsSP+0tr1ewi6ChpgbBAJoB9nxTAnTWZJxb3g4UkY KweQYifwzgaqH5Y0Y5ktUHqOKtN3pNcmcQovsp1rD7XkSysf6gCE6dYIEFXyfKyvwiRs+H vOVE4hE4smXNry6EhQLiIxzLSExllSaztAJY99wuTIiM1ROog0T6qrWWyipe9hogs4M8RC RUgwyI2VDxlJqkNlarZKgLAqKuzuK/tSSYMqxAbfT9xbhbD4kzzfp/ZF9YuUOQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1771208324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u0B5+BSo14q2vID9Y4iDRd5Ns56Q6yb52saMNU1B+8M=; b=nvwBcl7lE5ovJBhJzlpVhz2TSORGWvxanUXcZU8DOu/PSJjIhtXx6FJz9vMk7/O9NUhNOm Cm2Y0en5pankJsRcgdDvwfjnQGHQt5BapOoL7wnHyx9UcYtYGCkdr9yx2jKge0oX8T8wH1 VtYRcqEgpQaIGjlzmKkgYDYmZQ5wEiiDubG3yJGPvsQYI79r/Vf2HsEC5bohP6iBNgYl5B QhgxOFsAgmfjgmgQGBXGvjNd8C7+3qIEa7kNjujETXnv2U0tDo/yjEStbZfiRDe32xhI7i muHF3M/75+tf74fyrzH+Aw9gsNfaeCS7zZYXVhaUJ4lhCBzViBp/VOa3s4+UGQ== Received: from ltc.des.dev (2a01cb0585090500922e16fffef1acef.ipv6.abo.wanadoo.fr [IPv6:2a01:cb05:8509:500:922e:16ff:fef1:acef]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: des) by smtp.freebsd.org (Postfix) with ESMTPSA id 4fDmfX3QtszBLD; Mon, 16 Feb 2026 02:18:44 +0000 (UTC) (envelope-from des@freebsd.org) Received: by ltc.des.dev (Postfix, from userid 1001) id 408477534D; Mon, 16 Feb 2026 03:18:43 +0100 (CET) From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= To: Eugene Grosbein Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 8f8a7f6fffd7 - main - libfetch: apply timeout to SSL_read() In-Reply-To: (Eugene Grosbein's message of "Mon, 16 Feb 2026 09:06:02 +0700") References: <6971e2fa.d8f3.445991e5@gitrepo.freebsd.org> <86pl651mku.fsf@ltc.des.dev> User-Agent: Gnus/5.13 (Gnus v5.13) Date: Mon, 16 Feb 2026 03:18:43 +0100 Message-ID: <86fr711ldo.fsf@ltc.des.dev> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Eugene Grosbein writes: > [moving to developers] [moving back where it belongs] > Dag-Erling Sm=C3=B8rgrav writes: > > I did not review or approve this, and it is incorrect. > Sorry, I did not check MAINTAINERS, indeed. Mea culpa. > But, why is it incorrect? It was tested by other users of FreeBSD and > it works for me and them. * It has almost as many style violations as lines of code. * It's in the wrong place. You're calling setsockopt() once per read operation instead of once per connection. * It doesn't fix unencrypted connections. * It's the wrong solution. As explained in code comments, libfetch was designed to work with non-blocking sockets. All you needed to do was restore the fcntl() call that was accidentally dropped a while ago. DES --=20 Dag-Erling Sm=C3=B8rgrav - des@FreeBSD.org