From owner-freebsd-current@freebsd.org Wed Feb 17 18:46:41 2021 Return-Path: Delivered-To: freebsd-current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 9E05652A939 for ; Wed, 17 Feb 2021 18:46:41 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mailman.nyi.freebsd.org (unknown [127.0.1.3]) by mx1.freebsd.org (Postfix) with ESMTP id 4Dgmyn2xFrz4vck for ; Wed, 17 Feb 2021 18:46:41 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mailman.nyi.freebsd.org (Postfix) id 62DFE52AAEF; Wed, 17 Feb 2021 18:46:41 +0000 (UTC) Delivered-To: current@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 629D852AD84 for ; Wed, 17 Feb 2021 18:46:41 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Dgmym5bjRz4vlx for ; Wed, 17 Feb 2021 18:46:40 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wm1-x331.google.com with SMTP id v62so4521125wmg.4 for ; Wed, 17 Feb 2021 10:46:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=v0fa0eNyj0w57OBhXg7hj4Ppb0t1JHTa2rTFAfFzK2s=; b=YGFZZe1hrl/OtSLhzMadqheP7cH0bMXv6Rt95u24P4nQ44J5qLv6sToqpBxZIZkW8p RCDavaeHpLSZQQT2dgZSb431/tAGphIYvjKqz8LhJwXaYPyL0HiHST2R90VbFYlOuRgI TVYjNs2sfgj4lm/hp3ZpG9UWJmfoUUYCylp0Z/wNp3X/MMMrDln8F5SdnALztCMAcDlX 9734Rev7IZE0jmL6/RdN5whOqs80CxlMB8c++sKOPaa38VEvQwqxffHMpwk4IOGiQGWp +WANPieana7EeawxfZCJZs8VC8ffr1QeBEt+mGxQf2NOd5FYISGYfRfr/bl/aLKqS9jw akIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=v0fa0eNyj0w57OBhXg7hj4Ppb0t1JHTa2rTFAfFzK2s=; b=Omz8JvnYAdD8dVMarZp2UcY17p2o7Udy04BHDoGrp29jyEEv3VZ7e9Sp6fjitLmncR 4E553EQ9Xolun8F07+/lINPfHGaQNbtGIAK/zful8aA0fmKdDbADgPNC9bD4t9P9rZ0g In/HzzJu36bApiqP5TO1Ht9wiDG9D1hisr4B1/tUCr3nnWbRrqfcQeFMmS21LsDCgRqi 4Ocvutcm0nkzlgt/aHHaA98kbsqHQt7oytvfbPvyx/TWmuzA923QLeh9EavYBAtGxnUv na8rw+pogbXf0NtYD3KhFQTLEj+XkvQ+F6kQ2gNb4VhalEskexW47rsSWvBOZ6HrgHj7 e+1A== X-Gm-Message-State: AOAM531X2ku/+az0OsDcOBy4jVTA4f9SqViPA9GPcMMAWIfOMzYV/qug pfZv6in/KjVD7HE5fDl/cm8Dnhlt4iI= X-Google-Smtp-Source: ABdhPJytnapJRmrcEQxa0y5ITT39GTy9RV7CuYFnKu5zYBNf9ekohakK3Oc8Mx0rE11hn3BBaq1WMA== X-Received: by 2002:a1c:7409:: with SMTP id p9mr242667wmc.95.1613587598934; Wed, 17 Feb 2021 10:46:38 -0800 (PST) Received: from ernst.home (p5b02350e.dip0.t-ipconnect.de. [91.2.53.14]) by smtp.gmail.com with ESMTPSA id 2sm5647908wre.24.2021.02.17.10.46.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 10:46:38 -0800 (PST) Date: Wed, 17 Feb 2021 19:46:35 +0100 From: Gary Jennejohn To: current@freebsd.org Subject: Re: unused function errors in tcp_lro.c Message-ID: <20210217184635.52fb12d2@ernst.home> In-Reply-To: <20210217171239.53abc343@ernst.home> References: <20210217171239.53abc343@ernst.home> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.17.5 (GTK+ 2.24.33; amd64-portbld-freebsd13.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4Dgmym5bjRz4vlx X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20161025 header.b=YGFZZe1h; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of gljennjohn@gmail.com designates 2a00:1450:4864:20::331 as permitted sender) smtp.mailfrom=gljennjohn@gmail.com X-Spamd-Result: default: False [-4.00 / 15.00]; HAS_REPLYTO(0.00)[gljennjohn@gmail.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; R_SPF_ALLOW(-0.20)[+ip6:2a00:1450:4000::/36:c]; FREEMAIL_FROM(0.00)[gmail.com]; REPLYTO_ADDR_EQ_FROM(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; DKIM_TRACE(0.00)[gmail.com:+]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_HAM_SHORT(-1.00)[-1.000]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US]; RBL_DBL_DONT_QUERY_IPS(0.00)[2a00:1450:4864:20::331:from]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; ARC_NA(0.00)[]; NEURAL_HAM_MEDIUM(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20161025]; RECEIVED_SPAMHAUS_PBL(0.00)[91.2.53.14:received]; FROM_HAS_DN(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FREEMAIL_REPLYTO(0.00)[gmail.com]; PREVIOUSLY_DELIVERED(0.00)[current@freebsd.org]; RCPT_COUNT_ONE(0.00)[1]; SPAMHAUS_ZRD(0.00)[2a00:1450:4864:20::331:from:127.0.2.255]; RCVD_IN_DNSWL_NONE(0.00)[2a00:1450:4864:20::331:from]; RCVD_TLS_ALL(0.00)[]; MAILMAN_DEST(0.00)[current] X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Feb 2021 18:46:41 -0000 On Wed, 17 Feb 2021 18:12:39 +0100 Gary Jennejohn wrote: > Running buildkernel after 48e62e6561b..effe8b9cb31 > > -------------------------------------------------------------- > >>> stage 3.1: building everything > -------------------------------------------------------------- > /usr/src/sys/netinet/tcp_lro.c:1297:1: warning: unused function 'build_ack_entry' [-Wunused-function] > build_ack_entry(struct tcp_ackent *ae, struct tcphdr *th, struct mbuf *m, uint16_t hdr_len, uint16_t iptos) > ^ > /usr/src/sys/netinet/tcp_lro.c:1339:1: warning: unused function 'do_bpf_and_csum' [-Wunused-function] > do_bpf_and_csum(struct inpcb *inp, struct lro_ctrl *lc, struct lro_entry *le, > ^ > 2 warnings generated. > > These function declarations should be gated using #ifdef TCPHPTS. > Thanks for fixing this, but now afer 962a3814d4c..ab4fad4be14 I get -------------------------------------------------------------- >>> stage 3.1: building everything -------------------------------------------------------------- /usr/src/sys/netinet/tcp_lro.c:474:1: warning: unused function 'tcp_lro_log' [-Wunused-function] tcp_lro_log(struct tcpcb *tp, struct lro_ctrl *lc, ^ 1 warning generated. This function is also only used when TCPHPTS is defined. -- Gary Jennejohn