From owner-svn-src-all@freebsd.org Sat Oct 24 15:55:09 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B1724A1D347; Sat, 24 Oct 2015 15:55:09 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from mx1.stack.nl (relay02.stack.nl [IPv6:2001:610:1108:5010::104]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client CN "mailhost.stack.nl", Issuer "CA Cert Signing Authority" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 51CD71F33; Sat, 24 Oct 2015 15:55:09 +0000 (UTC) (envelope-from jilles@stack.nl) Received: from snail.stack.nl (snail.stack.nl [IPv6:2001:610:1108:5010::131]) by mx1.stack.nl (Postfix) with ESMTP id E918C358C67; Sat, 24 Oct 2015 17:55:05 +0200 (CEST) Received: by snail.stack.nl (Postfix, from userid 1677) id CAC7028494; Sat, 24 Oct 2015 17:55:05 +0200 (CEST) Date: Sat, 24 Oct 2015 17:55:05 +0200 From: Jilles Tjoelker To: Baptiste Daroussin Cc: Bryan Drewery , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r289879 - head/usr.sbin/newsyslog Message-ID: <20151024155505.GA39162@stack.nl> References: <201510241355.t9ODtCnp039885@repo.freebsd.org> <562BA43A.50806@FreeBSD.org> <20151024153946.GD40371@ivaldir.etoilebsd.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20151024153946.GD40371@ivaldir.etoilebsd.net> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Oct 2015 15:55:09 -0000 On Sat, Oct 24, 2015 at 05:39:47PM +0200, Baptiste Daroussin wrote: > On Sat, Oct 24, 2015 at 08:31:06AM -0700, Bryan Drewery wrote: > > On 10/24/15 6:55 AM, Baptiste Daroussin wrote: > > > +static int > > > +parse_signal(const char *str) > > Maybe this and the timeout(1) version should move to libc or libutil. We > > do have strsignal(3) and psignal(3) too. > I was thinking about moving parse_signal to libutil yes. There is similar code in sh(1) (for trap) and kill(1). In either case, "0", "00", etc. are valid, unlike in timeout(1) and newsyslog(8). In kill(1)'s case, the error messages are more detailed. I'm not going to add a dependency on libutil in such basic utilities though. In my humble opinion, depending on another DSO is more expensive than having a small piece of duplicated code. -- Jilles Tjoelker