From owner-svn-ports-all@FreeBSD.ORG  Wed Nov  6 13:55:14 2013
Return-Path: <owner-svn-ports-all@FreeBSD.ORG>
Delivered-To: svn-ports-all@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 68BE2267;
 Wed,  6 Nov 2013 13:55:14 +0000 (UTC)
 (envelope-from martymac@FreeBSD.org)
Received: from lmtp.galacsys.net (webmail.galacsys.net
 [IPv6:2001:1b78:0:1:d918:51d7:0:1])
 by mx1.freebsd.org (Postfix) with ESMTP id 30289214A;
 Wed,  6 Nov 2013 13:55:14 +0000 (UTC)
Received: from martymac.org (webmail.galacsys.net [217.24.81.215])
 by lmtp.galacsys.net (Postfix) with ESMTP id 848711FA5D35;
 Wed,  6 Nov 2013 14:55:13 +0100 (CET)
From: "Ganael LAPLANCHE" <martymac@FreeBSD.org>
To: Alexey Dokuchaev <danfe@FreeBSD.org>,
 Ganael LAPLANCHE <martymac@FreeBSD.org>
Subject: Re: svn commit: r332953 - head/benchmarks/nttcp
X-Openwebmail-Date: Wed, 6 Nov 2013 15:55:13 +0200
Message-Id: <20131106135212.M16907@FreeBSD.org>
In-Reply-To: <20131106081815.GB90001@FreeBSD.org>
References: <201311060811.rA68BbBe077262@svn.freebsd.org>
 <20131106081815.GB90001@FreeBSD.org>
X-Mailer: Open WebMail 2.01 20030425
X-OriginatingIP: 157.99.64.43 (ganael.laplanche@martymac.org)
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Date: Wed,  6 Nov 2013 13:55:14 +0000 (UTC)
Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 06 Nov 2013 13:55:14 -0000

On Wed, 6 Nov 2013 08:18:15 +0000, Alexey Dokuchaev wrote

Hi Alexey,

> >  ALL_TARGET=	nttcp
> > -MAN1=		nttcp.1
> > -PLIST_FILES=	bin/nttcp
> > +PLIST_FILES=	bin/nttcp man/man1/nttcp.1.gz
> 
> We usually try to move out PLIST_* knobs in separate block.

You mean having a blank line between MAN1 and PLIST_FILES, right ?
  
> > -	${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${PREFIX}/bin/
> > -	${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${PREFIX}/man/man1/
> > +	${INSTALL_PROGRAM} ${WRKSRC}/nttcp ${STAGEDIR}${PREFIX}/bin/
> > +	${INSTALL_MAN} ${WRKSRC}/nttcp.1 ${STAGEDIR}${PREFIX}/man/man1/
> 
> Manual pages should be installed relative to MAN[n]PREFIX, not 
> PREFIX.

Oops, thanks for having spotted this ! I'll fix that ASAP.

Best regards,

--
Ganael LAPLANCHE <ganael.laplanche@martymac.org>
http://www.martymac.org | http://contribs.martymac.org
FreeBSD: martymac <martymac@FreeBSD.org>, http://www.FreeBSD.org