Date: Wed, 23 Jul 2008 16:06:24 +0100 From: "Florent Thoumie" <flz@xbsd.org> To: "Ion-Mihai Tetcu" <itetcu@freebsd.org> Cc: ports@freebsd.org, Olafur Osvaldsson <osvaldsson@icelandic.net>, pgollucci@freebsd.org, araujo@freebsd.org Subject: Re: ports/125625: [PATCH] dns/nsd: USE_RC_SUBR != yes Message-ID: <a01628140807230806v1706061aqd15d5825d6dbbb1@mail.gmail.com> In-Reply-To: <20080723151212.18dfb88d@it.buh.tecnik93.com> References: <1592773212-1216766394-cardhu_decombobulator_blackberry.rim.net-2001801074-@bxe056.bisx.produk.on.blackberry> <a01628140807230314r247cd0b2h5da1138ca0a5b67@mail.gmail.com> <F6E63544-13DD-4464-8EA5-C6D977176A0E@icelandic.net> <a01628140807230508g340aac64x78eeeb8e9a637079@mail.gmail.com> <20080723151212.18dfb88d@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Jul 23, 2008 at 1:12 PM, Ion-Mihai Tetcu <itetcu@freebsd.org> wrote: > On Wed, 23 Jul 2008 13:08:03 +0100 > "Florent Thoumie" <flz@xbsd.org> wrote: > >> On Wed, Jul 23, 2008 at 12:30 PM, Olafur Osvaldsson >> <osvaldsson@icelandic.net> wrote: >> > This is something the PR responsible introduced in his original >> > patch... >> >> It's still present in your version. Anyway, I'm not blaming anyone, >> just pointing out what I think is a mistake. > > So this is not for the user but for the port? > > I'll do a swap on the tree for it, because I'm sure there are more > ports doing something like: > .ifndef(NO_INSTALL_MANPAGES) > ...... > .endif The general rule of thumb is: if it doesn't begin with WITH_ or WITHOUT_, it's not user-settable. NO_INSTALL_MANPAGES is used for ports using imake that don't understand the install.man target. Now of course there are exceptions (usually for no good reason IMHO). The likes of NOPORTDOCS/NOPORTEXAMPLES/... could be changed to WITHOUT_DOCS/WITHOUT_EXAMPLES, it's just waiting for somebody to do the work. -- Florent Thoumie flz@FreeBSD.org FreeBSD Committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?a01628140807230806v1706061aqd15d5825d6dbbb1>