From owner-freebsd-bugs@FreeBSD.ORG Tue Dec 9 05:20:04 2003 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 004F016A4CE for ; Tue, 9 Dec 2003 05:20:04 -0800 (PST) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 43CD743D21 for ; Tue, 9 Dec 2003 05:20:03 -0800 (PST) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.12.9/8.12.9) with ESMTP id hB9DK3FY093454 for ; Tue, 9 Dec 2003 05:20:03 -0800 (PST) (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.9/8.12.9/Submit) id hB9DK3YG093452; Tue, 9 Dec 2003 05:20:03 -0800 (PST) (envelope-from gnats) Date: Tue, 9 Dec 2003 05:20:03 -0800 (PST) Message-Id: <200312091320.hB9DK3YG093452@freefall.freebsd.org> To: freebsd-bugs@FreeBSD.org From: Yar Tikhiy Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Yar Tikhiy List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Dec 2003 13:20:04 -0000 The following reply was made to PR kern/47920; it has been noted by GNATS. From: Yar Tikhiy To: Gleb Smirnoff , FreeBSD-gnats-submit@FreeBSD.ORG, freebsd-bugs@FreeBSD.ORG Cc: Subject: Re: kern/47920: if ng_pppoe switches to nonstandard mode it stays in it forever Date: Tue, 9 Dec 2003 16:14:41 +0300 I would rather change the name of the variable "nonstandard" to "pppoe_mode", not "standard", because lines like this one: standard = PPPOE_NONSTANDARD; give me a schizoid feeling :-) I also believe you should not omit the "freebsd-gnats-submit@freebsd.org" address from the list of recipients when sending a follow-up to a PR, or else GNATS will not be able to add your follow-up to the audit trail. -- Yar