From owner-freebsd-security Sat Mar 31 10:17:42 2001 Delivered-To: freebsd-security@freebsd.org Received: from ints.ru (ints.ru [195.9.37.1]) by hub.freebsd.org (Postfix) with ESMTP id DDBFB37B718 for ; Sat, 31 Mar 2001 10:17:35 -0800 (PST) (envelope-from ilmar@ints.ru) Received: from ws-ilmar.ints.ru (ws-ilmar.ints.ru [195.9.37.16]) by ints.ru (8.11.0/8.11.0) with ESMTP id f2VIHYt04547 for ; Sat, 31 Mar 2001 22:17:34 +0400 (MSD) Date: Sat, 31 Mar 2001 22:17:31 +0400 (MSD) From: "Ilmar S. Habibulin" To: Subject: pam_unix logging patch Message-ID: MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-1436966727-986062651=:89026" Sender: owner-freebsd-security@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. Send mail to mime@docserver.cac.washington.edu for more info. --0-1436966727-986062651=:89026 Content-Type: TEXT/PLAIN; charset=US-ASCII Here is a patch for log user logins and logouts, that i made in 15 minutes while studying login&PAM. Why not to use LOG_AUTH and pam_system_log() with other usefull pam functions to log different events? And i don't understand why not to move half of login stuff to pam modules, or even use only pam without ifdefs? PS. patch is against -current. --0-1436966727-986062651=:89026 Content-Type: TEXT/PLAIN; charset=US-ASCII; name="pam_unix.c.patch" Content-Transfer-Encoding: BASE64 Content-ID: Content-Description: Content-Disposition: attachment; filename="pam_unix.c.patch" LS0tIHBhbV91bml4LmMJU2F0IE1heSAgOCAwNTo1OToyNyAxOTk5DQorKysg cGFtX3R1bml4LmMJU2F0IE1hciAzMSAyMjowMzo0NyAyMDAxDQpAQCAtMzcs NiArMzcsOCBAQA0KIA0KICNkZWZpbmUgUEFNX1NNX0FVVEgNCiAjZGVmaW5l IFBBTV9TTV9BQ0NPVU5UDQorI2RlZmluZSBQQU1fU01fU0VTU0lPTg0KKw0K ICNpbmNsdWRlIDxzZWN1cml0eS9wYW1fbW9kdWxlcy5oPg0KIA0KICNpbmNs dWRlICJwYW1fbW9kX21pc2MuaCINCkBAIC0xNTgsNiArMTYwLDk1IEBADQog CX0NCiANCiAJbG9naW5fY2xvc2UobGMpOw0KKwlyZXR1cm4gcmV0dmFsOw0K K30NCisNCisvKg0KKyNkZWZpbmUgT1BFTl9TRVNTSU9OX0xPRyAiXA0KK3Nl cnZpY2U6ICVzXG5cDQordXNlciAgIDogJXNcblwNCit0dHkgICAgOiAlc1xu XA0KK2hvc3QgICA6ICVzXG4iDQorKi8NCisNCisjZGVmaW5lIE9QRU5fU0VT U0lPTl9MT0cgImxvZ2luIHVzZXIgJXMgb24gJXMgZnJvbSAlcyINCisvKiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIF4gICAgIF4gICAg ICAgXg0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg fCAgICAgfCAgICAgICB8DQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICB8ICAgICB8ICAgICAgICstIGhvc3RuYW1lDQorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgICArLSB0dHkN CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICstIHVz ZXIgbmFtZQ0KKyovDQorI2RlZmluZSBDTE9TRV9TRVNTSU9OX0xPRyAibG9n b3V0IHVzZXIgJXMgb24gJXMgZnJvbSAlcyINCisNCitQQU1fRVhURVJOIGlu dA0KK3BhbV9zbV9vcGVuX3Nlc3Npb24ocGFtX2hhbmRsZV90ICpwYW1oLCBp bnQgZmxhZ3MsIGludCBhcmdjLA0KKyAgICBjb25zdCBjaGFyICoqYXJndikN Cit7DQorCWNvbnN0IGNoYXIgKnVzZXI7DQorCWNvbnN0IGNoYXIgKnNlcnZp Y2U7DQorCWNvbnN0IGNoYXIgKnR0eTsNCisJY29uc3QgY2hhciAqcmhvc3Q7 DQorCWludCByZXR2YWw7DQorDQorCXJldHZhbCA9IHBhbV9nZXRfaXRlbShw YW1oLCBQQU1fVVNFUiwgKGNvbnN0IHZvaWQgKiopJnVzZXIpOw0KKwlpZiAo cmV0dmFsICE9IFBBTV9TVUNDRVNTIHx8IHVzZXIgPT0gTlVMTCkNCisJCXJl dHVybiBQQU1fVVNFUl9VTktOT1dOOw0KKw0KKwlyZXR2YWwgPSBwYW1fZ2V0 X2l0ZW0ocGFtaCwgUEFNX1NFUlZJQ0UsIChjb25zdCB2b2lkICoqKSZzZXJ2 aWNlKTsNCisJaWYgKHJldHZhbCAhPSBQQU1fU1VDQ0VTUyB8fCBzZXJ2aWNl ID09IE5VTEwpDQorCQlyZXR1cm4gUEFNX1NFUlZJQ0VfRVJSOw0KKw0KKwly ZXR2YWwgPSBwYW1fZ2V0X2l0ZW0ocGFtaCwgUEFNX1RUWSwgKGNvbnN0IHZv aWQgKiopJnR0eSk7DQorCWlmIChyZXR2YWwgIT0gUEFNX1NVQ0NFU1MgfHwg dHR5ID09IE5VTEwpDQorCQlyZXR1cm4gUEFNX1NFUlZJQ0VfRVJSOw0KKw0K KwlyZXR2YWwgPSBwYW1fZ2V0X2l0ZW0ocGFtaCwgUEFNX1JIT1NULCAoY29u c3Qgdm9pZCAqKikmcmhvc3QpOw0KKwlpZiAocmV0dmFsICE9IFBBTV9TVUND RVNTKQ0KKwkJcmV0dXJuIFBBTV9TRVJWSUNFX0VSUjsNCisvKg0KKwlwcmlu dGYoInBhbV9zbV9vcGVuX3Nlc3Npb24oKSB1aWQ9JWRcbiIsIGdldHVpZCgp KTsNCisqLw0KKwlwYW1fc3lzdGVtX2xvZyhwYW1oLCBOVUxMLCBMT0dfQVVU SHxMT0dfSU5GTywNCisJCQlPUEVOX1NFU1NJT05fTE9HLCB1c2VyLCB0dHks IA0KKwkJCXJob3N0ID8gcmhvc3QgOiAibG9jYWxob3N0Iik7DQorCXJldHZh bCA9IFBBTV9TVUNDRVNTOw0KKwlyZXR1cm4gcmV0dmFsOw0KK30NCisNCitQ QU1fRVhURVJOIGludA0KK3BhbV9zbV9jbG9zZV9zZXNzaW9uKHBhbV9oYW5k bGVfdCAqcGFtaCwgaW50IGZsYWdzLCBpbnQgYXJnYywNCisgICAgY29uc3Qg Y2hhciAqKmFyZ3YpDQorew0KKwljb25zdCBjaGFyICp1c2VyOw0KKwljb25z dCBjaGFyICpzZXJ2aWNlOw0KKwljb25zdCBjaGFyICp0dHk7DQorCWNvbnN0 IGNoYXIgKnJob3N0Ow0KKwlpbnQgcmV0dmFsOw0KKw0KKwlyZXR2YWwgPSBw YW1fZ2V0X2l0ZW0ocGFtaCwgUEFNX1VTRVIsIChjb25zdCB2b2lkICoqKSZ1 c2VyKTsNCisJaWYgKHJldHZhbCAhPSBQQU1fU1VDQ0VTUyB8fCB1c2VyID09 IE5VTEwpDQorCQkvKiBzb21lIGltcGxlbWVudGF0aW9ucyByZXR1cm4gUEFN X1NVQ0NFU1MgaGVyZSAqLw0KKwkJcmV0dXJuIFBBTV9VU0VSX1VOS05PV047 DQorDQorCXJldHZhbCA9IHBhbV9nZXRfaXRlbShwYW1oLCBQQU1fU0VSVklD RSwgKGNvbnN0IHZvaWQgKiopJnNlcnZpY2UpOw0KKwlpZiAocmV0dmFsICE9 IFBBTV9TVUNDRVNTIHx8IHNlcnZpY2UgPT0gTlVMTCkNCisJCXJldHVybiBQ QU1fU0VSVklDRV9FUlI7DQorDQorCXJldHZhbCA9IHBhbV9nZXRfaXRlbShw YW1oLCBQQU1fVFRZLCAoY29uc3Qgdm9pZCAqKikmdHR5KTsNCisJaWYgKHJl dHZhbCAhPSBQQU1fU1VDQ0VTUyB8fCB0dHkgPT0gTlVMTCkNCisJCXJldHVy biBQQU1fU0VSVklDRV9FUlI7DQorDQorCXJldHZhbCA9IHBhbV9nZXRfaXRl bShwYW1oLCBQQU1fUkhPU1QsIChjb25zdCB2b2lkICoqKSZyaG9zdCk7DQor CWlmIChyZXR2YWwgIT0gUEFNX1NVQ0NFU1MpDQorCQlyZXR1cm4gUEFNX1NF UlZJQ0VfRVJSOw0KKw0KKwlwYW1fc3lzdGVtX2xvZyhwYW1oLCBOVUxMLCBM T0dfQVVUSHxMT0dfSU5GTywNCisJCQlDTE9TRV9TRVNTSU9OX0xPRywgdXNl ciwgdHR5LCANCisJCQlyaG9zdCA/IHJob3N0IDogImxvY2FsaG9zdCIpOw0K Ky8qDQorCXByaW50ZigicGFtX3NtX2Nsb3NlX3Nlc3Npb24gZm9yIHVzZXIg JXMsIHVpZCAlZFxuIiwgdXNlciwgZ2V0dWlkKCkpOw0KKyovDQorCXJldHZh bCA9IFBBTV9TVUNDRVNTOw0KIAlyZXR1cm4gcmV0dmFsOw0KIH0NCiANCg== --0-1436966727-986062651=:89026-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-security" in the body of the message