From nobody Tue Jan 23 19:01:19 2024
X-Original-To: dev-commits-ports-all@mlmmj.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
	by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4TKGdw60J4z57vXX;
	Tue, 23 Jan 2024 19:01:24 +0000 (UTC)
	(envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
	 client-signature RSA-PSS (4096 bits) client-digest SHA256)
	(Client CN "freefall.freebsd.org", Issuer "R3" (verified OK))
	by mx1.freebsd.org (Postfix) with ESMTPS id 4TKGdw5P1cz4PCD;
	Tue, 23 Jan 2024 19:01:24 +0000 (UTC)
	(envelope-from jbeich@freebsd.org)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim;
	t=1706036484;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=vCkANhggoLWr7tcLKTTBKMb7p8Y64sEDKLPCE41psZ0=;
	b=XbS0gBUJYA011Z1zPJzsAusVmPIi58OMxRWLVe5pt7zcUYWjQt52yk7o2ByoamduX8WkBt
	1J9B0R80s/0XJxwVjEcn/xUxGmubQ/N7NWJ8TXEX2uZffs7K8yN/XR1oaxtS3cNK0cb2aP
	N4brS0Xq1kyntnriDyskpQf+vO7eTUsdd9lspp/Nh/ojbDw121dtkEAqJeBJseW/FluI4J
	p2F9FFh5HzrAXddFqVyNqswLFAb4/olCHHRFK5aDTTJNOZWgApQsx1abZ3C9PVFvDc1ZXd
	GnmvePSpSMGeWn3ivAlEND9eJijI5KBJTwcpPj1OdPjBWDS+Wf56Ls2vCdw7Uw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org;
	s=dkim; t=1706036484;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 in-reply-to:in-reply-to:references:references;
	bh=vCkANhggoLWr7tcLKTTBKMb7p8Y64sEDKLPCE41psZ0=;
	b=b6tx2CwzXmfoy9nY6aAtw1ksb/9sjH63QD7xao48DDZuvPk1GtOOVp2K59F4wybBsW13eO
	LkVbdYUlmZf04b7EQcjokjbZC5aDH3Bsv13zOlglDIwNk5RzvsSxvuOsefHdArUBCiT/dO
	xzMFA7u6iT1+VDoVni4htob0YBIgh/T6SGsnaJrUKjmi2QRe3Ia1FGIzW8qL5zU0KoSRI4
	TMoJqTGkWQgRX127UVbSnMyM4C0rzhyItk5SZ/mC6RR8blAI7DVKhFq4FZMrG1IBOIfvp6
	1P/GwBYiu6yJDUnjyPeCuvhisKraC43bihfhScsR9yP+BoZ0/8Tmm9joeNy2wQ==
ARC-Authentication-Results: i=1;
	mx1.freebsd.org;
	none
ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1706036484; a=rsa-sha256; cv=none;
	b=G6rjtcABGdx6lhti7HeXGU48DMJ1ctgRgfEJo0TA1NOO3gX8tOVdIzRO67/kj4COV9Tg2x
	kdB8ujqyTPzPueenuPlbOu3rSwlstaPT8FN1D0Ad+qkUEssDuV6vTAsPLuzP5f2GmQgidw
	iiThQ+5OrfNcuNXNOXbXgODNzKJwqsjhDjz55H/1ow82ElLB2li0cdBiICf9vX+b31Fw3S
	s/8EiPrggcP0l6T97n1FhlMQgsouo1rRHW4phPb/wipQ4hAu8XfuUQetE3zU55dRFWGGq/
	od/BfGpQoyke+8FbsDXU8n7WKPatjt2YOvVR3CmNmlzoV3lCko9jPdcwfhVUkg==
Received: by freefall.freebsd.org (Postfix, from userid 1354)
	id 868921745; Tue, 23 Jan 2024 19:01:23 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Dries Michiels <driesm@FreeBSD.org>
Cc: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org,
	dev-commits-ports-main@FreeBSD.org
Subject: Re: git: 184188b65d98 - main - net-p2p/lidarr: fix finding fpcalc
In-Reply-To: <202401231849.40NInsva079956__21024.779572484$1706035808$gmane$org@gitrepo.freebsd.org>
	(Dries Michiels's message of "Tue, 23 Jan 2024 18:49:54 GMT")
References: <202401231849.40NInsva079956__21024.779572484$1706035808$gmane$org@gitrepo.freebsd.org>
Date: Tue, 23 Jan 2024 20:01:19 +0100
Message-ID: <ede7-nabk-wny@FreeBSD.org>
List-Id: Commit messages for all branches of the ports repository <dev-commits-ports-all.freebsd.org>
List-Archive: https://lists.freebsd.org/archives/dev-commits-ports-all
List-Help: <mailto:dev-commits-ports-all+help@freebsd.org>
List-Post: <mailto:dev-commits-ports-all@freebsd.org>
List-Subscribe: <mailto:dev-commits-ports-all+subscribe@freebsd.org>
List-Unsubscribe: <mailto:dev-commits-ports-all+unsubscribe@freebsd.org>
Sender: owner-dev-commits-ports-all@freebsd.org
X-BeenThere: dev-commits-ports-all@freebsd.org
MIME-Version: 1.0
Content-Type: text/plain

Dries Michiels <driesm@FreeBSD.org> writes:

> diff --git a/net-p2p/lidarr/files/lidarr.in b/net-p2p/lidarr/files/lidarr.in
> index 3b9bf2480f37..df009015b687 100644
> --- a/net-p2p/lidarr/files/lidarr.in
> +++ b/net-p2p/lidarr/files/lidarr.in
> @@ -33,6 +33,8 @@ command="/usr/sbin/daemon"
>  
>  start_precmd=${name}_precmd
>  %%PORTNAME%%_precmd() {
> +    export PATH="/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin"

Why not use %%LOCALBASE%% instead of hardcoding /usr/local? See
https://docs.freebsd.org/en/books/porters-handbook/pkg-files/#using-sub-files

$ make -V '${SUB_LIST:M*LOCALBASE*}'
LOCALBASE=/usr/local
$ make -V '${SUB_FILES:M${PORTNAME}}'
lidarr lidarr