Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Apr 2018 14:00:44 -0700
From:      Cy Schubert <Cy.Schubert@cschubert.com>
To:        Konstantin Belousov <kostikbel@gmail.com>
Cc:        Cy Schubert <cy@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r331943 - head/include
Message-ID:  <201804032100.w33L0i5g024502@slippy.cwsent.com>
In-Reply-To: Message from Konstantin Belousov <kostikbel@gmail.com> of "Tue, 03 Apr 2018 23:40:57 %2B0300." <20180403204057.GM1774@kib.kiev.ua>

next in thread | previous in thread | raw e-mail | index | archive | help
In message <20180403204057.GM1774@kib.kiev.ua>, Konstantin Belousov 
writes:
> On Tue, Apr 03, 2018 at 08:14:37PM +0000, Cy Schubert wrote:
> > Author: cy
> > Date: Tue Apr  3 20:14:37 2018
> > New Revision: 331943
> > URL: https://svnweb.freebsd.org/changeset/base/331943
> > 
> > Log:
> >   Include update to stdio.h missed in r331936.
> >   
> >   In my attempt to limit the commit in r331936 to only the gets_s()
> >   commit and not include unrelated patches in my tree, this patch
> >   was missed.
> >   
> >   Reported by:	pfg
> >   MFC after:	2 weeks
> >   X-MFC with:	r331936
> >   Differential Revision:	https://reviews.freebsd.org/D12785
> > 
> > Modified:
> >   head/include/stdio.h
> > 
> > Modified: head/include/stdio.h
> > ===========================================================================
> ===
> > --- head/include/stdio.h	Tue Apr  3 19:51:23 2018	(r331942)
> > +++ head/include/stdio.h	Tue Apr  3 20:14:37 2018	(r331943)
> > @@ -51,6 +51,11 @@ typedef	__size_t	size_t;
> >  #define	_SIZE_T_DECLARED
> >  #endif
> >  
> > +#ifndef _RSIZE_T_DEFINED
> > +#define _RSIZE_T_DEFINED
> > +typedef size_t rsize_t;
> > +#endif
> > +
> >  #if __POSIX_VISIBLE >= 200809
> >  #ifndef _OFF_T_DECLARED
> >  #define	_OFF_T_DECLARED
> > @@ -265,6 +270,9 @@ size_t	 fwrite(const void * __restrict, size_t, size_t
> >  int	 getc(FILE *);
> >  int	 getchar(void);
> >  char	*gets(char *);
> > +#if defined(__EXT1_VISIBLE) && __EXT1_VISIBLE == 1
> What is the purpose of the __EXT1_VISIBLE == 1 check ?
> It is against the intended __XX_VISIBLE mechanism construction.

That appears to have been left over in my commit tree.

>
> > +char	*gets_s(char *, rsize_t); 
> > +#endif
> >  void	 perror(const char *);
> >  int	 printf(const char * __restrict, ...);
> >  int	 putc(int, FILE *);

-- 
Cheers,
Cy Schubert <Cy.Schubert@cschubert.com>
FreeBSD UNIX:  <cy@FreeBSD.org>   Web:  http://www.FreeBSD.org

	The need of the many outweighs the greed of the few.





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804032100.w33L0i5g024502>