Date: Sun, 18 Jun 2000 16:32:36 +0200 From: Johan Karlsson <k@numeri.campus.luth.se> To: Brian Somers <brian@Awfulhak.org> Cc: brian@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG, brian@hak.lan.awfulhak.org Subject: Re: cvs commit: src Makefile.inc1 Message-ID: <200006181432.QAA82361@numeri.campus.luth.se> In-Reply-To: Your message of "Sun, 18 Jun 2000 14:21:49 BST." <200006181321.OAA68493@hak.lan.Awfulhak.org>
next in thread | previous in thread | raw e-mail | index | archive | help
At Sun, 18 Jun 2000 14:21:49 BST, Brian Somers wrote:
>
>On one of my machines at work, I have the following in /etc/make.conf:
>
>KERNEL=? DBT1 DBT5 UKNOWN1835
>
>I expect to build all three kernels as a result, but when I ``make
>installkernel'', Makefile.inc1 takes steps to set INSTALLKERNEL to
>DBT1 - the first item in the KERNEL list.
>
>When the sys/conf/Makefile.$arch is used with an ``install'' target,
>it finds KERNEL in /etc/make.conf and overrides the environment
>setting, making a rather miserable attempt at running ${INSTALL}.
This is a problem for all variables set in Makefile.inc1 then.
I guess all location of such variables should be fixed not only this one.
>
>It would probably be cleaner if I had
>
>KERNEL?= DBT1 DBT5 UNKNOWN1835
>INSTALLKERNEL?= DBT1
>
>in make.conf, but I didn't think that was the correct solution as
>INSTALLKERNEL is just overridden in src/Makefile.inc1.
>
>Perhaps the correct solution is to default INSTALLKERNEL to the first
>item in the KERNEL list in both make files ?
>
My suggestion (which I'm implementing in a new version for PR kern/17698
is to use 'KERNELS' to specify more than one kernel to be build by
src/Makefile.inc1. Then install the first of those as 'kernel' and the
rest as 'kernel.${FOO}'.
I will send a follow-up to the PR i a while and maybe you can have a look at
the patch.
Thanks
Johan K
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200006181432.QAA82361>