From owner-freebsd-dtrace@FreeBSD.ORG  Sat Nov 15 21:05:17 2014
Return-Path: <owner-freebsd-dtrace@FreeBSD.ORG>
Delivered-To: freebsd-dtrace@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7D2F748E;
 Sat, 15 Nov 2014 21:05:17 +0000 (UTC)
Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 55DF781C;
 Sat, 15 Nov 2014 21:05:17 +0000 (UTC)
Received: from pool-96-250-5-187.nycmny.fios.verizon.net ([96.250.5.187]:53434
 helo=[192.168.1.11])
 by vps.hungerhost.com with esmtpsa (TLSv1:DHE-RSA-AES256-SHA:256)
 (Exim 4.82) (envelope-from <gnn@neville-neil.com>)
 id 1XpkWu-0006F0-HP; Sat, 15 Nov 2014 16:05:14 -0500
From: "George Neville-Neil" <gnn@neville-neil.com>
To: "Andriy Gapon" <avg@FreeBSD.org>
Subject: Re: removing solaris cyclic
Date: Sat, 15 Nov 2014 16:05:01 -0500
Message-ID: <BD16B946-5161-4755-A9D3-4199554450C0@neville-neil.com>
In-Reply-To: <5466225E.2050902@FreeBSD.org>
References: <543643A1.6030002@FreeBSD.org>
 <49A880FD-F346-4033-A1E5-BA1BB69FD2DA@neville-neil.com>
 <5466225E.2050902@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
X-Mailer: MailMate (1.8r4576)
X-AntiAbuse: This header was added to track abuse,
 please include it with any abuse report
X-AntiAbuse: Primary Hostname - vps.hungerhost.com
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - neville-neil.com
X-Get-Message-Sender-Via: vps.hungerhost.com: authenticated_id:
 gnn@neville-neil.com
Cc: freebsd-dtrace@FreeBSD.org
X-BeenThere: freebsd-dtrace@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: "A discussion list for developers working on DTrace in FreeBSD."
 <freebsd-dtrace.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-dtrace>, 
 <mailto:freebsd-dtrace-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-dtrace/>
List-Post: <mailto:freebsd-dtrace@freebsd.org>
List-Help: <mailto:freebsd-dtrace-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-dtrace>,
 <mailto:freebsd-dtrace-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 15 Nov 2014 21:05:17 -0000

On 14 Nov 2014, at 10:40, Andriy Gapon wrote:

> On 09/10/2014 18:34, George Neville-Neil wrote:
>> On 9 Oct 2014, at 4:13, Andriy Gapon wrote:
>>
>>> I would like to ask for a review and/or testing of the following 
>>> branch
>>> for a phased removal of solaris cyclic code:
>>> https://github.com/avg-I/freebsd/compare/review/no-cyclic Raw diff:
>>> https://github.com/avg-I/freebsd/compare/master...review/no-cyclic.diff
>>>
>>> The only user of cyclic now is DTrace profile provider, so I am
>>> converting it to use our improved callout(9).  cyclic is almost a
>>> complete implementation of an alternative to our callout(9), so 
>>> having
>>> that big chunk of foreign code which duplicates a core function is 
>>> not
>>> nice.
>>>
>>> One thing that I am not sure about is what PROF_ARTIFICIAL_FRAMES 
>>> should
>>> be on different platforms.  Also, I am not sure if the number of
>>> interrupt, timer, etc frames depends on a timer being used.  I'd
>>> appreciate any help on this.
>>
>> Can you create a reviews.freebsd.org patch for this?
>
> Done: https://reviews.freebsd.org/D1161
>

Yup, reviewed.  I'm hoping at least one other person on that review 
lists comments
and if it's OK then commit it.

Best,
George