From owner-freebsd-mips@FreeBSD.ORG Tue Apr 24 06:59:41 2012 Return-Path: Delivered-To: freebsd-mips@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DA99F106564A; Tue, 24 Apr 2012 06:59:41 +0000 (UTC) (envelope-from c.jayachandran@gmail.com) Received: from mail-wg0-f50.google.com (mail-wg0-f50.google.com [74.125.82.50]) by mx1.freebsd.org (Postfix) with ESMTP id 19AB98FC17; Tue, 24 Apr 2012 06:59:40 +0000 (UTC) Received: by wgbds12 with SMTP id ds12so293107wgb.31 for ; Mon, 23 Apr 2012 23:59:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=g3qIPRzX7WBHIRdLxHKkOBSjNwPlvZFVF0Ak7is81o8=; b=bvYcq5+9BAVSKmEp8vsgph5Wj5wjyvXaOftZ1i0bv1SIJ8rWE/Bz8DgzKiTUnYxy9C T1EJ4nFpmQD3VaVvq6zDA8uLv3yXpD9xjojT4/KVcf0qXEyMgKOtchxKSchgmDoe+UKO bz/ztsweuW+4cYVrjI8w90axshFEFgQXSPi34GQ4SkkeaMu5DmQF0/AzbuvbsqKPuHDP EHLDx/WUchV2lrQS4Ozw1Q0LG3YxuyWVglt1ltFacjHC4R89QMub6bnVFajN0h8AHMcA 26xJMsf2tCkE/qmvYUpYRSvt6bzcxw4AFWnhr/ScWHe57sO0xO+hKFQPeMgoyF2KN3rZ t2Bg== MIME-Version: 1.0 Received: by 10.180.102.101 with SMTP id fn5mr28293867wib.6.1335250780299; Mon, 23 Apr 2012 23:59:40 -0700 (PDT) Sender: c.jayachandran@gmail.com Received: by 10.216.60.71 with HTTP; Mon, 23 Apr 2012 23:59:40 -0700 (PDT) In-Reply-To: References: <201204170722.q3H7ME6A070934@svn.freebsd.org> Date: Tue, 24 Apr 2012 12:29:40 +0530 X-Google-Sender-Auth: ytBxKP3zoGfSBa9rLenakjNMJc4 Message-ID: From: "Jayachandran C." To: Jason Evans Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Cc: freebsd-mips@freebsd.org Subject: Re: svn commit: r234370 - in head: contrib/jemalloc contrib/jemalloc/doc contrib/jemalloc/include contrib/jemalloc/include/jemalloc contrib/jemalloc/include/jemalloc/internal contrib/jemalloc/src inclu... X-BeenThere: freebsd-mips@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to MIPS List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2012 06:59:41 -0000 On Tue, Apr 24, 2012 at 12:15 PM, Jason Evans wrote: > On Apr 23, 2012, at 11:35 PM, Jayachandran C. wrote: >> On Tue, Apr 17, 2012 at 12:52 PM, Jason Evans wrote= : >>> Author: jasone >>> Date: Tue Apr 17 07:22:14 2012 >>> New Revision: 234370 >>> URL: http://svn.freebsd.org/changeset/base/234370 >> >> [....] >>> +diff --git a/include/jemalloc/jemalloc_FreeBSD.h b/include/jemalloc/je= malloc_FreeBSD.h >>> +new file mode 100644 >>> +index 0000000..2c5797f >>> +--- /dev/null >>> ++++ b/include/jemalloc/jemalloc_FreeBSD.h >>> +@@ -0,0 +1,76 @@ >> [....] >>> ++#ifdef __mips__ >>> ++# =A0define LG_SIZEOF_PTR =A0 =A0 =A0 =A0 =A0 =A0 =A0 2 >>> ++#endif >> >> This breaks 64-bit mips platforms. I have a simple patch that fixes >> this at http://people.freebsd.org/~jchandra/jemalloc.patch >> >> Another possible fix suggested by Juli is to do >> #define =A0LG_SIZEOF_PTR _MIPS_SZPTR >> >> Can you please check-in one of these? =A0If you are busy, I can do the >> check-in if you approve the changes. > > I had planned to do this, based on Juli's suggestion: > >> #ifdef __mips__ >> # =A0if (_MIPS_SZPTR =3D=3D 64) >> # =A0 =A0define LG_SIZEOF_PTR 3 >> # =A0else >> # =A0 =A0define LG_SIZEOF_PTR 2 >> # =A0endif >> #endif > > Feel free to check in whichever approach you feel is cleaner. =A0I can't = test it, so you might as well do the honors. =3D) I seems to have mis-understood Juli's suggestion (sorry). Do I need to update the FREEBSD-diffs file as well? Thanks, JC.