From owner-svn-ports-all@freebsd.org  Sun Jul  5 19:26:42 2020
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.nyi.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.nyi.freebsd.org (Postfix) with ESMTP id 8060134AFAC;
 Sun,  5 Jul 2020 19:26:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256
 client-signature RSA-PSS (4096 bits) client-digest SHA256)
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id 4B0Jbk2pDPz4HY5;
 Sun,  5 Jul 2020 19:26:42 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id 47CD216712; Sun,  5 Jul 2020 19:26:42 +0000 (UTC)
Date: Sun, 5 Jul 2020 19:26:42 +0000
From: Alexey Dokuchaev <danfe@freebsd.org>
To: "Tobias C. Berner" <tcberner@freebsd.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r541296 - in head: databases/kexi devel/injeqt
 textproc/libkolabxml x11/sddm
Message-ID: <20200705192642.GA32791@FreeBSD.org>
References: <202007051920.065JKLK1093017@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <202007051920.065JKLK1093017@repo.freebsd.org>
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.33
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 05 Jul 2020 19:26:42 -0000

On Sun, Jul 05, 2020 at 07:20:21PM +0000, Tobias C. Berner wrote:
> New Revision: 541296
> URL: https://svnweb.freebsd.org/changeset/ports/541296
> 
> Log:
>   Switch to using CMAKE_ON/CMAKE_OFF instead of more clunky CMAKE_ARGS
> 
> Modified: head/x11/sddm/Makefile
> ...
> +CMAKE_ON=	BUILD_MAN_PAGES
>  CMAKE_ARGS=	-DUID_MIN=1000 \
>  		-DUID_MAX=65000 \
>  		-DCMAKE_INSTALL_SYSCONFDIR:PATH=${LOCALBASE}/etc \
> -		-DBUILD_MAN_PAGES=ON \
>  		-DRST2MAN_EXECUTABLE=${LOCALBASE}/bin/rst2man.py-${PYTHON_VER}

This one looks like pessimization.  Please be more considerate with these
changes; I, for one, do not like CMAKE_ON/OFF as I find it harder to read
and understand and prefer explicit assignments via CMAKE_ARGS.

./danfe