Date: Sun, 5 Jul 2020 19:26:42 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: "Tobias C. Berner" <tcberner@freebsd.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r541296 - in head: databases/kexi devel/injeqt textproc/libkolabxml x11/sddm Message-ID: <20200705192642.GA32791@FreeBSD.org> In-Reply-To: <202007051920.065JKLK1093017@repo.freebsd.org> References: <202007051920.065JKLK1093017@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, Jul 05, 2020 at 07:20:21PM +0000, Tobias C. Berner wrote: > New Revision: 541296 > URL: https://svnweb.freebsd.org/changeset/ports/541296 > > Log: > Switch to using CMAKE_ON/CMAKE_OFF instead of more clunky CMAKE_ARGS > > Modified: head/x11/sddm/Makefile > ... > +CMAKE_ON= BUILD_MAN_PAGES > CMAKE_ARGS= -DUID_MIN=1000 \ > -DUID_MAX=65000 \ > -DCMAKE_INSTALL_SYSCONFDIR:PATH=${LOCALBASE}/etc \ > - -DBUILD_MAN_PAGES=ON \ > -DRST2MAN_EXECUTABLE=${LOCALBASE}/bin/rst2man.py-${PYTHON_VER} This one looks like pessimization. Please be more considerate with these changes; I, for one, do not like CMAKE_ON/OFF as I find it harder to read and understand and prefer explicit assignments via CMAKE_ARGS. ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200705192642.GA32791>