From owner-svn-src-projects@freebsd.org Wed Aug 16 15:01:45 2017 Return-Path: Delivered-To: svn-src-projects@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3FDC2DE0D3F for ; Wed, 16 Aug 2017 15:01:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0433D1EDB for ; Wed, 16 Aug 2017 15:01:45 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by mail-io0-x233.google.com with SMTP id c74so13884348iod.4 for ; Wed, 16 Aug 2017 08:01:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=XjIL10xyQvzwn6ddRncZgYZAQL7HOQbP4A5kED68byc=; b=LO5MsNtlBk7AOyzLhwIFqmBDSVyxmqmePD070hM4o6mgp1mH1IMyVzMtDrM2nWuWaV eo2Ud7MHXo0qGW6Lsx/MuYyya+YxiedY0/Q+44lBV9zhRAWq2p5ZYM8uhxf49DoUQl0y Q8/4+4CjtiUdhwEW3cNM1RL/0VbLvfFfU86XD1bgvy1OpuX8/xGu3gQhyYDVpSYfVWPb Fz0JmRTaKlPHo0WqkoiV7AjObc34xXK3y6h3IV9Xq3dAVaXdROuACH0xP9DIpsOPxR6I rlLbmCNTlU4jEC4gfh04yt6gd5ABwdlpcCIiV2zaQ+2WYTCiE17x03rkd8imkMBLWjtv HvOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=XjIL10xyQvzwn6ddRncZgYZAQL7HOQbP4A5kED68byc=; b=MwEAgbRpphIXf+cO8Pi50u62e6Ta+1nxMsrOP33dHfSXBlPCObXD5vVdtnEclCf5ua I6YLRfqp++On2t5xVgxfYweCnoJc0IXo2V/i6sGaddZ2FiIIKcHX5aUcrEl29RzwNzxL cznBPIJbwlb9uMK/3CrxEhVnp54pXXnLcxcuN1Fifo3znynXs8noOZCpAkk3QVNAGBSE sH4uo1ehnszIhroviaQJxIhHfAg3lpfhUHh6v/37HIk/i3KRTxEG90Ei9YSZsk6tfdhX Tmoor8C8tZZ+QUNwcY8ZgPhmNA/VMl+12sUh51Kylj+bnagJBLV0cKrxcuOdn6c1aoDc kDuw== X-Gm-Message-State: AHYfb5jQqZO9Q2xnfEG5+LrD5t/FIyW3dlbFwcuxxEeJNyJuCcvBh6kT 0q7bw0yikk2BLQ6JRMkMadLGZdpWFOQt X-Received: by 10.107.136.104 with SMTP id k101mr1696508iod.62.1502895702985; Wed, 16 Aug 2017 08:01:42 -0700 (PDT) MIME-Version: 1.0 Sender: wlosh@bsdimp.com Received: by 10.79.10.71 with HTTP; Wed, 16 Aug 2017 08:01:42 -0700 (PDT) X-Originating-IP: [50.253.99.174] In-Reply-To: <4555783.zflod2nrqZ@ralph.baldwin.cx> References: <201708152027.v7FKR89U031476@repo.freebsd.org> <4555783.zflod2nrqZ@ralph.baldwin.cx> From: Warner Losh Date: Wed, 16 Aug 2017 09:01:42 -0600 X-Google-Sender-Auth: V-M8JikUaBJjxDs92CSNFUW0h_Q Message-ID: Subject: Re: svn commit: r322551 - in projects/runtime-coverage/sys/boot: efi/boot1 efi/loader geli i386/boot2 i386/btx/lib i386/gptboot i386/gptzfsboot i386/loader i386/zfsboot mips/beri/loader powerpc/kboot p... To: John Baldwin Cc: Ngie Cooper , src-committers , svn-src-projects@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: svn-src-projects@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the src " projects" tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Aug 2017 15:01:45 -0000 On Wed, Aug 16, 2017 at 7:41 AM, John Baldwin wrote: > On Tuesday, August 15, 2017 08:27:08 PM Ngie Cooper wrote: > > Author: ngie > > Date: Tue Aug 15 20:27:07 2017 > > New Revision: 322551 > > URL: https://svnweb.freebsd.org/changeset/base/322551 > > > > Log: > > Disable MK_COVERAGE in sys/boot/... > > > > None of this should be compiled with MK_COVERAGE enabled, and it > > fails to compile with it enabled due to unresolved symbols. > > Would it be a smaller change to make use of Makefile.inc for this? > > It looks like there is already a sys/boot/Makefile.inc to set other > settings that affect all of sys/boot and the various subdirectories of > sys/boot all have Makefile.inc's that include ../Makefile.inc. > I think something like this is preferable. We have way too much duplication in these makefiles as it is and this makes it incrementally worse. If someone else doesn't beat me to it, I'll give it a shot. IIRC, at least in the past there's some thorny issues with doing multiple levels of include like this, but that may just be in the old fmake, not the current bmake. Warner