Date: Mon, 2 Oct 2000 16:30:18 -0400 (EDT) From: root@misha.privatelabs.com To: FreeBSD-gnats-submit@freebsd.org Subject: ports/21709: textproc/wordnet MAINTAINER UPGRADE Message-ID: <200010022030.e92KUI407459@misha.privatelabs.com>
next in thread | raw e-mail | index | archive | help
>Number: 21709
>Category: ports
>Synopsis: textproc/wordnet MAINTAINER UPGRADE
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Mon Oct 02 13:40:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator: Mikhail Teterin
>Release: FreeBSD 4.1.1-STABLE i386
>Organization:
Virtual Estates, Inc.
>Environment:
>Description:
The included patch fixes a bug documented on the software's
site, documents one of the patch-files, bumps up the TCL/TK
version in use to 8.3 and adds the WWW field to pkg/DESCR.
>How-To-Repeat:
>Fix:
--- Makefile Mon Oct 2 16:24:44 2000
+++ Makefile Mon Oct 2 15:41:49 2000
@@ -17 +17 @@
-LIB_DEPENDS= tk82.1:${PORTSDIR}/x11-toolkits/tk82
+LIB_DEPENDS= tk83.1:${PORTSDIR}/x11-toolkits/tk83
@@ -27 +27 @@
-TCL_DVER= 8.2
+TCL_DVER= 8.3
--- files/src.wnb.Makefile Sun Apr 30 22:40:47 2000
+++ files/src.wnb.Makefile Mon Oct 2 15:54:39 2000
@@ -2 +2 @@
-TCL_DVER?= 8.2
+TCL_DVER?= 8.3
--- patches/patch-official Sun Apr 30 22:40:49 2000
+++ patches/patch-official Mon Oct 2 15:51:33 2000
@@ -0,0 +1,11 @@
+This patch mostly contains the differences between the search.c as in
+the released version 1.6 vs. the later version found in
+ ftp://ftp.cogsci.princeton.edu/pub/wordnet/bugfixes/
+
+I also modified the groupexc function to fix the problem documented in
+ ftp://ftp.cogsci.princeton.edu/pub/wordnet/README.bugs
+(buf[8] vs. buf[9] -- point 5 at the bottom) and modified it to avoid
+allocating 1Kb from the stack and needlessly strcpy the argument given.
+Nothing gets written into the string anyway, and we can examine it
+without making a duplicate copy. -mi
+
@@ -20,0 +32,21 @@
+@@ -1405,16 +1405,15 @@
+
+ static int groupexc(unsigned long off1, unsigned long off2)
+ {
+- char buf[8], *p, linebuf[1024];
++ char buf[9], *p, *line;
+
+ sprintf(buf, "%8.8lu", (off1 < off2 ? off1 : off2));
+
+ if ((p = bin_search(buf, cousinexcfp)) != NULL) {
+ sprintf(buf, "%8.8lu", (off2 > off1 ? off2 : off1));
+- strcpy(linebuf, p + 9); /* don't copy key */
+- linebuf[strlen(linebuf) - 1] = '\0'; /* strip off newline */
+- p = strtok(linebuf, " ");
+- while (p && strcmp(p, buf))
++ line = p + 9; /* ignore the key */
++ p = strtok(line, " ");
++ while (p && strncmp(p, buf, 8))
+ p = strtok(NULL, " ");
+ }
+ return(p ? 1 : 0);
--- pkg/DESCR Sun Apr 30 22:40:50 2000
+++ pkg/DESCR Mon Oct 2 15:57:22 2000
@@ -10,0 +11,2 @@
+
+WWW: http://www.cogsci.princeton.edu/~wn/
>Release-Note:
>Audit-Trail:
>Unformatted:
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200010022030.e92KUI407459>