From owner-freebsd-current@FreeBSD.ORG  Tue Aug 24 15:49:08 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 9EB71106567A;
	Tue, 24 Aug 2010 15:49:08 +0000 (UTC)
	(envelope-from rbgarga@gmail.com)
Received: from mail-ey0-f182.google.com (mail-ey0-f182.google.com
	[209.85.215.182])
	by mx1.freebsd.org (Postfix) with ESMTP id 051CE8FC19;
	Tue, 24 Aug 2010 15:49:07 +0000 (UTC)
Received: by eyx24 with SMTP id 24so3507254eyx.13
	for <multiple recipients>; Tue, 24 Aug 2010 08:49:06 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:received:mime-version:received:in-reply-to
	:references:from:date:message-id:subject:to:cc:content-type
	:content-transfer-encoding;
	bh=W4VhxRii+ldf85XWAfqS45vZpxF0rEQwhxMdAxQt8fA=;
	b=P2wcLn6EscnOLNjNG/yK4z7Jz0fAFtDOaA+Az1tyhlWaYTwTN9FCL5qXzf2/ifyKE3
	HAK13m+nRJjNroUZwFn6fQZk6MHVU4o3DKdeVn/xsNkB3i3RnkBG8CEuQSxRWuRFh4zJ
	wsd6P9bbsO01V1Vl6PkXH/w1p640PbiAN7Kuc=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:in-reply-to:references:from:date:message-id:subject:to
	:cc:content-type:content-transfer-encoding;
	b=BdZqACemoIrntDVGop+eO8TBHit2id/UaZSCBPqtZt8RXWURU0HNDLGkstCkt5+jM6
	NcVHYQ7c3bevI71Ne4QLGe6EL9rCrjl7f1GqQQ7m3atZtA2mN87dRpldPVhe9oSxZgx0
	g/iDyZ1ynIkwl5O105Pe/sVyJGdxxqXHZp5a8=
Received: by 10.216.90.8 with SMTP id d8mr4103444wef.89.1282663558252; Tue, 24
	Aug 2010 08:25:58 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.216.156.3 with HTTP; Tue, 24 Aug 2010 08:25:37 -0700 (PDT)
In-Reply-To: <20100823211257.GI2396@deviant.kiev.zoral.com.ua>
References: <4C7011B9.4020902@protected-networks.net>
	<20100822132104.GA7300@x2.osted.lan>
	<20100823211257.GI2396@deviant.kiev.zoral.com.ua>
From: Renato Botelho <rbgarga@gmail.com>
Date: Tue, 24 Aug 2010 12:25:37 -0300
Message-ID: <AANLkTik8P3=9fAv-AfUxwDLpJ4=uMQfeQf-jF6k=8PnC@mail.gmail.com>
To: Kostik Belousov <kostikbel@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: Peter Holm <pho@freebsd.org>, Michael Butler <imb@protected-networks.net>,
	Jeff Roberson <jroberson@jroberson.net>, current@freebsd.org
Subject: Re: softupdate with journal panic
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Aug 2010 15:49:08 -0000

On Mon, Aug 23, 2010 at 6:12 PM, Kostik Belousov <kostikbel@gmail.com> wrot=
e:
>
> On Sun, Aug 22, 2010 at 03:21:04PM +0200, Peter Holm wrote:
> > On Sat, Aug 21, 2010 at 01:49:45PM -0400, Michael Butler wrote:
> > > While updating sysutils/coreutils port on -current as of this morning
> > > (SVN r211550), I noted a panic during the directory rename config tes=
t.
> > >
> >
> > Your problem seems identical to this report:
> >
> > http://docs.freebsd.org/cgi/mid.cgi?AANLkTinPjiOV21kDLZYV5WScrhLMN7DY8E=
8jVHWPU5mC
> >
> I believe that dotdotremref in this case is legitimately NULL. With this
> assumption, the following patch would help.
>
> diff --git a/sys/ufs/ffs/ffs_softdep.c b/sys/ufs/ffs/ffs_softdep.c
> index b666c0f..65e5255 100644
> --- a/sys/ufs/ffs/ffs_softdep.c
> +++ b/sys/ufs/ffs/ffs_softdep.c
> @@ -6770,7 +6794,8 @@ cancel_diradd(dap, dirrem, jremref, dotremref, dotd=
otremref)
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0mkdir->md_jaddref =3D NULL=
;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (mkdir->md_state & MKDI=
R_PARENT) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0if (cancel=
_jaddref(jaddref, NULL,
> - =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 &di=
rrem->dm_jwork) =3D=3D 0) {
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 &di=
rrem->dm_jwork) =3D=3D 0 &&
> + =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 dot=
dotremref !=3D NULL) {
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0free_jremref(dotdotremref);
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =
=A0 =A0dotdotremref =3D NULL;
> =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0}

I was having a kernel panic trying to build coreutils, at configure
time it make some tests with rename() and system crashed. It was
just happening on the box i'm using SUJ. After apply this patch
everything went fine. Thanks!

--
Renato Botelho