Date: Sat, 20 Dec 1997 07:19:07 -0700 From: Nate Williams <nate@mt.sri.com> To: dyson@FreeBSD.ORG Cc: gurney_j@resnet.uoregon.edu, julian@whistle.com, bde@FreeBSD.ORG, current@FreeBSD.ORG Subject: Re: Bruce vandalism again Message-ID: <199712201419.HAA24217@mt.sri.com> In-Reply-To: <199712200904.EAA04490@dyson.iquest.net> References: <19971219215030.56082@hydrogen.nike.efn.org> <199712200904.EAA04490@dyson.iquest.net>
next in thread | previous in thread | raw e-mail | index | archive | help
> John-Mark Gurney said: > > > I agree. This appears to be a seriously retrograde step. Bruce, why? > > > > easy, don't you guys read style(9)? > > Use of the __P macro in new code is discouraged, although modifications > > to existing files should be consistent with that file's conventions. > > > > all the other parts of the code in that file are K&R style... so you > > need to maintain that convention... > > > If style(9) is broken, which apparently it is, then it should be fixed. > It isn't a religious document, but one that should change with the times. I disagree. I'm with Bruce here in that you shouldn't 'bit by bit' change code to use new ANSI prototypes *UNLESS* you change all of the code to use ANSI prototypes. So, either convert them all to the new style (my preference), or leave them all the old style, but having a mix/match of both is silly. And, if you want to change it all to the new style, make the 'style' changes commits separate from the functional changes commits so one can see the functionality changes easy w/out having to dig through the style changes. Nate
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712201419.HAA24217>