From owner-freebsd-hackers@FreeBSD.ORG  Tue Sep 30 22:45:17 2008
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0678C106568F;
	Tue, 30 Sep 2008 22:45:17 +0000 (UTC) (envelope-from daniel@roe.ch)
Received: from hobbes.ustdmz.roe.ch (hobbes.ustdmz.roe.ch [213.144.141.27])
	by mx1.freebsd.org (Postfix) with ESMTP id B66398FC1F;
	Tue, 30 Sep 2008 22:45:16 +0000 (UTC) (envelope-from daniel@roe.ch)
Received: from roe by hobbes.ustdmz.roe.ch (envelope-from <daniel@roe.ch>)
	with LOCAL id 1Kknzc-0004yR-00 ; Wed, 01 Oct 2008 00:46:56 +0200
Date: Wed, 1 Oct 2008 00:46:55 +0200
From: Daniel Roethlisberger <daniel@roe.ch>
To: freebsd-hackers@freebsd.org
Message-ID: <20080930224655.GG11823@hobbes.ustdmz.roe.ch>
Mail-Followup-To: freebsd-hackers@freebsd.org,
	=?iso-8859-1?Q?S=F8ren?= Schmidt <sos@FreeBSD.org>
References: <20080929230655.GA16790@hobbes.ustdmz.roe.ch>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080929230655.GA16790@hobbes.ustdmz.roe.ch>
User-Agent: Mutt/1.5.4i
Cc: =?iso-8859-1?Q?S=F8ren?= Schmidt <sos@FreeBSD.org>
Subject: Re: ATA Security patch to atacontrol
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 30 Sep 2008 22:45:17 -0000

Daniel Roethlisberger <daniel@roe.ch> 2008-09-30:
> I've added experimental support for the ATA Security command set to
> atacontrol.  Please test and review.  If you have some spare disk(s)
> with ATA Security support and a BIOS which does not freeze the security
> configuration, I'd like to hear about any results of playing with this
> patch.  See the changes to the manual page for details on the commands.
> 
> Note that you may render disks unusable using the ATA Security commands.
> Use with great care.

I've slightly improved the patch.  Changes:
- More sane timeouts on ATA commands
- Print a security usage if parameters are illegal
- Extended the manual page with some examples and notes about which
  commands are lethal to mounted filesystems
- Teach the kernel about the ATA Security command codes (for console
  printf messages)

Even with the kernel changes, a kernel rebuild is not required in order
to test the code.

http://daniel.roe.ch/code/ata/atasecurity-20081001-complete.diff

Please send me feedback.

-- 
Daniel Roethlisberger
http://daniel.roe.ch/