From owner-svn-src-all@FreeBSD.ORG Mon May 4 16:51:05 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 4F8E73A2 for ; Mon, 4 May 2015 16:51:05 +0000 (UTC) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:1900:2254:206c::16:87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 1AB821761 for ; Mon, 4 May 2015 16:51:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.9/8.14.9) with ESMTP id t44Gp4uM093149 for ; Mon, 4 May 2015 16:51:04 GMT (envelope-from bdrewery@freefall.freebsd.org) Received: (from bdrewery@localhost) by freefall.freebsd.org (8.14.9/8.14.9/Submit) id t44Gp4wI093144 for svn-src-all@freebsd.org; Mon, 4 May 2015 16:51:04 GMT (envelope-from bdrewery) Received: (qmail 40321 invoked from network); 4 May 2015 11:51:03 -0500 Received: from unknown (HELO ?10.10.1.139?) (freebsd@shatow.net@10.10.1.139) by sweb.xzibition.com with ESMTPA; 4 May 2015 11:51:03 -0500 Message-ID: <5547A382.6070707@FreeBSD.org> Date: Mon, 04 May 2015 11:51:14 -0500 From: Bryan Drewery Organization: FreeBSD User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Baptiste Daroussin , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r282421 - in head: . etc References: <201505041634.t44GY9OV006741@svn.freebsd.org> In-Reply-To: <201505041634.t44GY9OV006741@svn.freebsd.org> OpenPGP: id=F9173CB2C3AAEA7A5C8A1F0935D771BB6E4697CF; url=http://www.shatow.net/bryan/bryan2.asc Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vf1Id4nejvtQlOW8hphsu1POdTKX3Q3vs" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 04 May 2015 16:51:05 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --vf1Id4nejvtQlOW8hphsu1POdTKX3Q3vs Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 5/4/2015 11:34 AM, Baptiste Daroussin wrote: > Author: bapt > Date: Mon May 4 16:34:08 2015 > New Revision: 282421 > URL: https://svnweb.freebsd.org/changeset/base/282421 >=20 > Log: > Remove now unneeded libmap32.conf This doesn't explain why; the commit message is useless. "Because r282420 ..." >=20 > Deleted: > head/etc/libmap32.conf > Modified: > head/ObsoleteFiles.inc > head/etc/Makefile >=20 > Modified: head/ObsoleteFiles.inc > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/ObsoleteFiles.inc Mon May 4 16:28:54 2015 (r282420) > +++ head/ObsoleteFiles.inc Mon May 4 16:34:08 2015 (r282421) > @@ -39,6 +39,7 @@ > # done > =20 > # 20150504 > +OLD_FILES+=3Detc/libmap32.conf This seems dangerous. I think only files no longer useful in any context should be added here. A user may have their own libmap32.conf that this would remove. Mergemaster/etcupdate might handle this case fine without delete-old. There are several other bugs with libmap32.conf: There's no manpage. There's no default /usr/local/etc/libmap32.d dir or entry. --=20 Regards, Bryan Drewery --vf1Id4nejvtQlOW8hphsu1POdTKX3Q3vs Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJVR6OCAAoJEDXXcbtuRpfPG+IIAKR287GRU5N+dUK2puz/LYjR l3c/+FSP5SkdO9nj8+cJGHsyWiNSB/xIVUOKAM2aQ9YOFKXVsOrIBGo0Q+/C8RXL kICMsIy24hs8NIpZ7htVDVnZVm5JNViKzppZmiglOJm/En047vzVVJCQjIE9TVfY zlbzD+i2B7AGT6qBS7z1UMw36mQiv7GPzfnn82ppIRHXCIKwSLcMxO8PajYTSD4W 55t18pLccI8pm4H9T9BPqracWNGJ5NlilztpogpLNdX5bnR0RRb82oMqnA0VJZzQ otFXfATfpaB614CJJ3dklwWwCrMc+xUo/2KaLF/0XkN9bjEL2TsDcVKugBF2U4Q= =NRBv -----END PGP SIGNATURE----- --vf1Id4nejvtQlOW8hphsu1POdTKX3Q3vs--