Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 25 Nov 1996 19:03:43 -0800 (PST)
From:      John-Mark Gurney <jmg@nike.efn.org>
To:        FreeBSD-gnats@freefall.FreeBSD.org
Subject:   misc/2105: bsd.lib.mk bugs
Message-ID:  <199611260303.TAA06775@nike.efn.org>
Resent-Message-ID: <199611260330.TAA02769@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         2105
>Category:       misc
>Synopsis:       bsd.lib.mk has problems with STRIP and INTERNALSTATICLIB
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Mon Nov 25 19:30:11 PST 1996
>Last-Modified:
>Originator:     John-Mark Gurney
>Organization:
Cu Networking
>Release:        FreeBSD 2.2-960801-SNAP i386
>Environment:

a 2.2-960803-SNAP but with current cvs tree... all patches relative to current
	

>Description:

a)	if you define INTERNALSTATICLIB, bsd.lib.mk still tries to install it, even though INTERNALLIB doesn't...
b)	INSTALL doesn't strip dynamic libs upon installing
	

>How-To-Repeat:

a)	define INTERNALSTATICLIB, and then do a make install, it installs

b)	install a dynamic library, file dynamic_lib, and see that it isn't stripped
	

>Fix:
	
apply this patch, a is the first hunk, b is the second:

Index: bsd.lib.mk
===================================================================
RCS file: /usr/cvs/src/share/mk/bsd.lib.mk,v
retrieving revision 1.37
diff -c -r1.37 bsd.lib.mk
*** bsd.lib.mk	1996/06/29 03:12:48	1.37
--- bsd.lib.mk	1996/11/26 02:57:47
***************
*** 199,205 ****
  .endif
  
  realinstall: beforeinstall
! .if !defined(INTERNALLIB)
  	${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
  	    ${INSTALLFLAGS} lib${LIB}.a ${DESTDIR}${LIBDIR}
  .if !defined(NOPROFILE)
--- 199,205 ----
  .endif
  
  realinstall: beforeinstall
! .if !defined(INTERNALLIB) && !defined(INTERNALSTATICLIB)
  	${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
  	    ${INSTALLFLAGS} lib${LIB}.a ${DESTDIR}${LIBDIR}
  .if !defined(NOPROFILE)
***************
*** 209,215 ****
  .endif
  .if !defined(NOPIC)
  .if defined(SHLIB_MAJOR) && defined(SHLIB_MINOR)
! 	${INSTALL} ${COPY} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
  	    ${INSTALLFLAGS} ${SHLINSTALLFLAGS} \
  	    lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR} \
  	    ${DESTDIR}${SHLIBDIR}
--- 209,215 ----
  .endif
  .if !defined(NOPIC)
  .if defined(SHLIB_MAJOR) && defined(SHLIB_MINOR)
! 	${INSTALL} ${COPY} ${STRIP} -o ${LIBOWN} -g ${LIBGRP} -m ${LIBMODE} \
  	    ${INSTALLFLAGS} ${SHLINSTALLFLAGS} \
  	    lib${LIB}.so.${SHLIB_MAJOR}.${SHLIB_MINOR} \
  	    ${DESTDIR}${SHLIBDIR}
	

>Audit-Trail:
>Unformatted:
John-Mark Gurney



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199611260303.TAA06775>