Date: Mon, 21 Jul 2003 00:48:40 +0200 From: Simon Barner <barner@in.tum.de> To: "Jacques A. Vidrine" <nectar@FreeBSD.org> Cc: Kris Kennaway <kris@obsecurity.org> Subject: Re: Fixing gcc 3.3 compile failures -- fix for math/freefem Message-ID: <20030720224840.GA731@zi025.glhnet.mhn.de> In-Reply-To: <20030719190500.GA19808@hellblazer.celabo.org> References: <20030718025200.GA36893@rot13.obsecurity.org> <20030719030539.GB467@zi025.glhnet.mhn.de> <20030719190500.GA19808@hellblazer.celabo.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--i9LlY+UWpKt15+FH
Content-Type: multipart/mixed; boundary="sdtB3X0nJg68CQEu"
Content-Disposition: inline
--sdtB3X0nJg68CQEu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Hi,
> > - ifstream fin( path );
> > + std::ifstream fin( path );
> A much smaller patch could be produced with
>=20
> using namespace std;
>=20
> as appropriate.
>=20
> Have you checked with the upstream author to see which approach is
> likely to be rolled into the distribution?
Actually, upgrading the port to the lastest freefem version would have
been enough *doh* :o) (patch attached)
To answer your question: the freefem authors decided not to use the
'using namespace std' approach.
Cheers,
Simon
--sdtB3X0nJg68CQEu
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment; filename="freefem-port.patch"
Content-Transfer-Encoding: quoted-printable
--- Makefile.orig Thu Jun 5 01:41:14 2003
+++ Makefile Mon Jul 21 00:42:53 2003
@@ -6,7 +6,7 @@
#
=20
PORTNAME=3D freefem
-PORTVERSION=3D 3.5.4
+PORTVERSION=3D 3.5.7
CATEGORIES=3D math cad
MASTER_SITES=3D ${MASTER_SITE_SOURCEFORGE}
MASTER_SITE_SUBDIR=3D kfem
@@ -24,10 +24,6 @@
MAN1=3D freefem.1
=20
.include <bsd.port.pre.mk>
-
-.if ${OSVERSION} >=3D 500113
-BROKEN=3D "Does not compile (bad C++ code)"
-.endif
=20
post-patch:
@${REINPLACE_CMD} -e 's|-O3 |\$$CXXFLAGS |g' ${WRKSRC}/configure
--- distinfo.orig Tue Mar 26 17:04:16 2002
+++ distinfo Mon Jul 21 00:38:13 2003
@@ -1 +1 @@
-MD5 (freefem-3.5.4.tar.gz) =3D 746fe6487085011493a805e23507ae30
+MD5 (freefem-3.5.7.tar.gz) =3D e8f22515ab56f8e79fb789a11f8d4bef
--sdtB3X0nJg68CQEu--
--i9LlY+UWpKt15+FH
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (FreeBSD)
iD8DBQE/GxxICkn+/eutqCoRAvk2AJ4hoJ86tk2/xnomQEVIMSc1/t01IgCfaK6f
nBZKFXCU1nIAfGZN4kf+vds=
=RH6x
-----END PGP SIGNATURE-----
--i9LlY+UWpKt15+FH--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030720224840.GA731>