From owner-cvs-all@FreeBSD.ORG Mon Dec 31 18:14:26 2007 Return-Path: Delivered-To: cvs-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 64DB516A417; Mon, 31 Dec 2007 18:14:26 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219]) by mx1.freebsd.org (Postfix) with ESMTP id D93B613C4E1; Mon, 31 Dec 2007 18:14:25 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from server.baldwin.cx (unverified [66.23.211.162]) by speedfactory.net (SurgeMail 3.8q) with ESMTP id 226821204-1834499 for multiple; Mon, 31 Dec 2007 13:16:50 -0500 Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id lBVIEFmQ098301; Mon, 31 Dec 2007 13:14:23 -0500 (EST) (envelope-from jhb@FreeBSD.org) From: John Baldwin To: Randall Stewart Date: Mon, 31 Dec 2007 12:19:07 -0500 User-Agent: KMail/1.9.6 References: <200712291507.lBTF7sTA069010@repoman.freebsd.org> In-Reply-To: <200712291507.lBTF7sTA069010@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200712311219.08286.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 31 Dec 2007 13:14:23 -0500 (EST) X-Virus-Scanned: ClamAV 0.91.2/5311/Mon Dec 31 12:05:08 2007 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet sctp_bsd_addr.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 31 Dec 2007 18:14:26 -0000 On Saturday 29 December 2007 10:07:54 am Randall Stewart wrote: > rrs 2007-12-29 15:07:54 UTC > > FreeBSD src repository > > Modified files: (Branch: RELENG_7_0) > sys/netinet sctp_bsd_addr.c > Log: > - sctp-iterator should run at PI_NET priority ...not 0. > Approved by: re@freebsd.org(gnn) > > Revision Changes Path > 1.14.4.1 +1 -1 src/sys/netinet/sctp_bsd_addr.c The more correct fix though is to do a 'sched_prio()' at the start of the thread's main loop to set the priority and then not adjust it via msleep(). Kernel threads really should never pass a priority to msleep() but always '0' (which means "don't change my priority"). -- John Baldwin