From owner-freebsd-arch Sun Mar 2 21:12:26 2003 Delivered-To: freebsd-arch@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id E3AD737B401 for ; Sun, 2 Mar 2003 21:12:24 -0800 (PST) Received: from puffin.mail.pas.earthlink.net (puffin.mail.pas.earthlink.net [207.217.120.139]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5E7A043FB1 for ; Sun, 2 Mar 2003 21:12:24 -0800 (PST) (envelope-from tlambert2@mindspring.com) Received: from pool0459.cvx21-bradley.dialup.earthlink.net ([209.179.193.204] helo=mindspring.com) by puffin.mail.pas.earthlink.net with asmtp (SSLv3:RC4-MD5:128) (Exim 3.33 #1) id 18piFN-00048y-00; Sun, 02 Mar 2003 21:12:18 -0800 Message-ID: <3E62E3B9.32887967@mindspring.com> Date: Sun, 02 Mar 2003 21:10:17 -0800 From: Terry Lambert X-Mailer: Mozilla 4.79 [en] (Win98; U) X-Accept-Language: en MIME-Version: 1.0 To: Jeff Roberson Cc: arch@FreeBSD.ORG Subject: Re: New getblk parameter. References: <20030302232340.R84333-100000@mail.chesapeake.net> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-ELNK-Trace: b1a02af9316fbb217a47c185c03b154d40683398e744b8a47470f5de6aafae7010021353932a0a7d666fa475841a1c7a350badd9bab72f9c350badd9bab72f9c Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG Jeff Roberson wrote: > On Sun, 2 Mar 2003, Terry Lambert wrote: > > If you are not going to change all the calls to getblk(), it > > should probably be a wrapper function, or, minimally, an inline > > and a wrapper function. > > > > The reasoning is that it chould be called from precompiled > > modules, so you want to leave a symbol visible for it, which > > defining it to getblkf(..., 0) doesn't do. > > Precompiled modules are already going to be broken with the new locking > semantics. I think requiring them to recompile is OK. I intend to bump > the FreeBSD version if this goes in. > > I'd sort of like to change all the getblk() calls actually. If no one > strongly objects to that I'll do it. I'd personally prefer that to the getblkf() thing. If you aren't making the change for a reason, like not wanting to change the ABI, that's one thing; but if it's going to trade out symbol space and a name obfuscation, it's best to just change them all. By my count, there's only about 60 of them, and it's a mechanical change that would take less than a minute with a modified cscope that can do parameter addition of the zero, or 5 minutes manually. You should just "go for it" (assuming RE@ OK's it). -- Terry To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message