Date: Sat, 12 Oct 2013 05:46:07 -0500 From: Bryan Drewery <bdrewery@FreeBSD.org> Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org Subject: Re: svn commit: r327601 - head/Mk Message-ID: <5259286F.5040501@FreeBSD.org> In-Reply-To: <52589A4E.3070506@FreeBSD.org> References: <201309190805.r8J855cW009011@svn.freebsd.org> <20130921023225.GA19307@FreeBSD.org> <20130921104936.GQ73535@ithaqua.etoilebsd.net> <523D7B20.6020908@FreeBSD.org> <alpine.LNX.2.00.1310120235240.2211@trevally.site> <52589A4E.3070506@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --WcRGjfPabwL8KsKSt4rh5WI4RRLKpF0e8 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 10/11/2013 7:39 PM, Bryan Drewery wrote: > On 10/11/2013 7:37 PM, Gerald Pfeifer wrote: >> On Sat, 21 Sep 2013, Bryan Drewery wrote: >>> We also plan to add more commit hooks for things that portlint has >>> checked for. Not everyone runs portlint, and portlint is essentially >>> unmaintained. It is currently severely lagging behind in feature-set >>> checking. By moving to ports, the feature-set checking is always >>> matching the tree. >> >> This is a bit confusing, and I think there are things portlint checks >> for that the ports infrastructure cannot? >> >> For example, a recent sweep to replace LAST_LINK by PKGNAMESUFFIX >> triggered new portlint warnings for me since PKGNAMESUFFIX was added >> at the wrong place. >=20 > This static analysis could be done by a hook. >=20 >> >> I thought we all are supposed to run portlint before commits? >=20 > Yes, but it's severely outdated and no one has stepped up to fix that o= r > take proper maintainership of it. It currently gives incorrect advice o= n > multiple common cases. I'm trying to resolve this in http://www.freebsd.org/cgi/query-pr.cgi?pr=3D182919 >=20 >> >> Gerald >> >=20 >=20 --=20 Regards, Bryan Drewery --WcRGjfPabwL8KsKSt4rh5WI4RRLKpF0e8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBAgAGBQJSWShwAAoJEG54KsA8mwz5cm0P/153w5JM/FYKCJWT5OoEKrR8 OkASrB+/fUd2iUNSI/jeZv51NZKuuBXTHaxJpmqulWgLWjCYQ3Eei7YH2HH5UwI3 L5kdem5SND9XiD5VRKaEbsoaFT0VQLN1hslqJtWjfzMrG1Eu/jbkBeH6oQZ5wAg2 2uwGhQFbhjZB+eSamX9B/Pk9yj2tuM6wo8dWLPmx8qVWM3lse/xUEphhTNa4nsEd auM56ly6xAPLahQQ3QowFJGPwXdKFrkOSnTZHg3rdFthlaPM+dUWXo+kmaELf7X3 oItBDefN0lASJBvTG2eZSJUEL82kX6fjYoluTy7ejRQmBhvLXzTYBXVrNRaxql1/ SAslVc3cjeL3XIW/8iIhy8F/dMldT7+DA4mqJX8wICRJCGLd55nJvukR0BsxmbOJ aqBPCdKIhRU5ORFvwftfkSqkjksXlWQj5QAiXkjTNWgmXUrSrQyd2Vrt6lNYrmt3 4P9hTt9gwqBF6BHSoPKsBOJv8DSVbB9VAHUOqIGp6PivBjY53CcSGlt1KDdOkmEU Fqwz0dDMaVeTGj/KaYM/bmLOLPhJX7oIQR2o3n8nlIo7h+/2ii/7CYJjjpB+RXNo 09iv1OUpEhLqn2FN1SVk8DIoYYYc7Q3a001OcHEh68IfcHLYqHcxDtJ6CXIrRCqt Kpn5GEuEm2r9iQbbpFEI =28+U -----END PGP SIGNATURE----- --WcRGjfPabwL8KsKSt4rh5WI4RRLKpF0e8--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5259286F.5040501>