From owner-cvs-all Mon Jan 15 11:28:40 2001 Delivered-To: cvs-all@freebsd.org Received: from meow.osd.bsdi.com (meow.osd.bsdi.com [204.216.28.88]) by hub.freebsd.org (Postfix) with ESMTP id 3FB6537B401; Mon, 15 Jan 2001 11:28:16 -0800 (PST) Received: from laptop.baldwin.cx (john@jhb-laptop.osd.bsdi.com [204.216.28.241]) by meow.osd.bsdi.com (8.11.1/8.9.3) with ESMTP id f0FJQq190743; Mon, 15 Jan 2001 11:26:52 -0800 (PST) (envelope-from jhb@FreeBSD.org) Message-ID: X-Mailer: XFMail 1.4.0 on FreeBSD X-Priority: 3 (Normal) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8bit MIME-Version: 1.0 In-Reply-To: <200101141936.f0EJaKM70546@freefall.freebsd.org> Date: Mon, 15 Jan 2001 11:28:24 -0800 (PST) From: John Baldwin To: SXren Schmidt Subject: RE: cvs commit: src/sys/dev/ata ata-all.c Cc: cvs-all@FreeBSD.org, cvs-committers@FreeBSD.org Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG On 14-Jan-01 SXren Schmidt wrote: > sos 2001/01/14 11:36:20 PST > > Modified files: > sys/dev/ata ata-all.c > Log: > Use prober atomic operations when test&set'ing ->active. > > This turns some of my lockups under SMP into spontanious reboots... Erm, all of this should be running under Giant, so you shouldn't be contending on this. You should probably protect this with a mutex that locks the softc rather than using atomic operations, btw. -- John Baldwin -- http://www.FreeBSD.org/~jhb/ PGP Key: http://www.baldwin.cx/~john/pgpkey.asc "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message