From owner-freebsd-bugs@freebsd.org  Wed Oct 21 12:43:20 2015
Return-Path: <owner-freebsd-bugs@freebsd.org>
Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26E64A1B2DF
 for <freebsd-bugs@mailman.ysv.freebsd.org>;
 Wed, 21 Oct 2015 12:43:20 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 1453919AB
 for <freebsd-bugs@FreeBSD.org>; Wed, 21 Oct 2015 12:43:20 +0000 (UTC)
 (envelope-from bugzilla-noreply@freebsd.org)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t9LChJbJ068247
 for <freebsd-bugs@FreeBSD.org>; Wed, 21 Oct 2015 12:43:19 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-bugs@FreeBSD.org
Subject: [Bug 203923] Coverity CID 975621: False positive
Date: Wed, 21 Oct 2015 12:43:20 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: new
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Base System
X-Bugzilla-Component: bin
X-Bugzilla-Version: 11.0-CURRENT
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Only Me
X-Bugzilla-Who: scdbackup@gmx.net
X-Bugzilla-Status: New
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform
 op_sys bug_status bug_severity priority component assigned_to reporter
Message-ID: <bug-203923-8@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs/>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Oct 2015 12:43:20 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203923

            Bug ID: 203923
           Summary: Coverity CID 975621: False positive
           Product: Base System
           Version: 11.0-CURRENT
          Hardware: Any
                OS: Any
            Status: New
          Severity: Affects Only Me
          Priority: ---
         Component: bin
          Assignee: freebsd-bugs@FreeBSD.org
          Reporter: scdbackup@gmx.net

usr.sbin/makefs/cd9660/cd9660_write.c

CID 975621 (#1 of 1): Copy-paste error (COPY_PASTE_ERROR)
   copy_paste_error: rf in fclose(rf) looks like a copy-paste error.
   Should it say fd instead?

471                        (void)fclose(rf);

--------------- Source analysis:

The suspicion stems from the assymetric reaction on error.
Only the read FILE pointer rf was opened inside the function.
So it gets closed in both error cases: with read FILE *rf and
with write FILE *fd.

          if (ferror(rf)) {
                  ...
                  (void)fclose(rf);
          ...
          if (ferror(fd)) {
                  ...
                  (void)fclose(rf);

--------------- Remedy proposal:

In Coverity classify CID 975621 as "False positive" and set its Action
to "Ignore".

-- 
You are receiving this mail because:
You are the assignee for the bug.