From owner-cvs-src@FreeBSD.ORG  Tue Sep 19 22:14:21 2006
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@freebsd.org
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id A4C8A16A403;
	Tue, 19 Sep 2006 22:14:21 +0000 (UTC)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (alchemy.franken.de [194.94.249.214])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 6008043D7F;
	Tue, 19 Sep 2006 22:14:05 +0000 (GMT)
	(envelope-from marius@alchemy.franken.de)
Received: from alchemy.franken.de (localhost [127.0.0.1])
	by alchemy.franken.de (8.13.8/8.13.8/ALCHEMY.FRANKEN.DE) with ESMTP id
	k8JME4Yo074883; Wed, 20 Sep 2006 00:14:04 +0200 (CEST)
	(envelope-from marius@alchemy.franken.de)
Received: (from marius@localhost)
	by alchemy.franken.de (8.13.8/8.13.8/Submit) id k8JME4nK074882;
	Wed, 20 Sep 2006 00:14:04 +0200 (CEST) (envelope-from marius)
Date: Wed, 20 Sep 2006 00:14:04 +0200
From: Marius Strobl <marius@alchemy.franken.de>
To: Ruslan Ermilov <ru@freebsd.org>
Message-ID: <20060919221404.GT94944@alchemy.franken.de>
References: <200609191303.k8JD3AHl050783@repoman.freebsd.org>
	<bb4a86c70609190944o2438a4a4vae7b3bb2332522ee@mail.gmail.com>
	<20060919190645.GA23068@rambler-co.ru>
	<bb4a86c70609191236j13fe1563w123cb046261ee129@mail.gmail.com>
	<20060919194819.GA23360@rambler-co.ru>
	<bb4a86c70609191300t3bea8380qa1898d1a89b6fc27@mail.gmail.com>
	<20060919203608.GE23360@rambler-co.ru>
	<bb4a86c70609191415m59a9ef89x91f25e6912339390@mail.gmail.com>
	<20060919215605.GB44298@rambler-co.ru>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20060919215605.GB44298@rambler-co.ru>
User-Agent: Mutt/1.4.2.2i
Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org,
	Maksim Yevmenkin <maksim.yevmenkin@gmail.com>
Subject: Re: cvs commit: src/sys/dev/kbdmux kbdmux.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Sep 2006 22:14:21 -0000

On Wed, Sep 20, 2006 at 01:56:05AM +0400, Ruslan Ermilov wrote:
> 
> The proper fix would be to fix the kernel to pass an argument by
> value, like the userland does.  But from the practical point of
> view, it may make sense to change the API and say that these
> IOCTLs now take a pointer type argument.  I'm not sure.  If you
> know of any applications (mine test util not counting :-) that
> use KDSKBMODE/KDSETLED/KDSKBSTATE, then we should probably fix
> the kernel callers.

XFree86/Xorg use KDSKBMODE and KDSETLED, see f.e. the Xorg
"kbd" driver:
http://webcvs.freedesktop.org/xorg/xserver/xorg/hw/xfree86/os-support/bsd/bsd_kbd.c?revision=1.8&view=markup

Marius