From owner-svn-src-all@freebsd.org Mon Sep 12 08:39:58 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 26CB0BD7E3D; Mon, 12 Sep 2016 08:39:58 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: from mail-vk0-x235.google.com (mail-vk0-x235.google.com [IPv6:2607:f8b0:400c:c05::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id D7040975; Mon, 12 Sep 2016 08:39:57 +0000 (UTC) (envelope-from sepherosa@gmail.com) Received: by mail-vk0-x235.google.com with SMTP id v189so123898122vkv.1; Mon, 12 Sep 2016 01:39:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:from:date:message-id :subject:to:cc; bh=kbBco9dIv7oYIJlhmjGhaO30B9ptsGC87MhXHDFMd+c=; b=sjc/j2+t19wmkqmETdEUVveWEaLHxpWed9kAtLIbI7+8cCTlHHlTTYXlNqiEG3r72P aBRfVfr1UbFp+dx+OcykA7OYylhC4232mFR1QmqDIKJUq6o3xNY5AS5NazCWeRE9nlCL IsyE63DItCXh1qQeqNFbCbxEdEo4tHdZSU5DimIAvPGuypt4NLwQ5wrhvEfNT/EtL/K8 xc7A2QeG5KvJz8i/HT/2P2DFFaerL151zJxdVbb3LAx5CcSdz6Btpb4y8ypT2vhLC4p3 ya/F1M8e6Ry14BRWJ0ps/gNqa1AfuN3SQO1pfeLvs4NSnTaS50byLKvIqfO5Ma6lAyDp 2UVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:from :date:message-id:subject:to:cc; bh=kbBco9dIv7oYIJlhmjGhaO30B9ptsGC87MhXHDFMd+c=; b=Uzyw55u9/rJBopr9sSUfYnngswDMxplru9cJqXxjkcFNx4oHvvqso2KLgyiKy1fDPs QQslsT6dCif8SiMLqf7a9+TPL2/TIZDO2FvTwQrjkEjIQhqNV5dMMleDzFsgI5uR6aun IFIBQeCfrsYcuzCM06SJuovRz6jlfV3Bq+h0/66MgHDgPuq8qaVobe95gpOs9XfOo9pw VuyO+wLr2hIduBC05C6Ip9UBmUC/E109MS9+jgSWd96jM7n+iLp6sMKZe7RPqJ17c/P3 N4ErLx1nfk2r/sc2lzYce/JMj0HX5h9goDgTxEo/puBYCN6F5oTU2NhAQaUFx8FZxJNO 1cjw== X-Gm-Message-State: AE9vXwM+sa7xSv2LfJbtVSryiHAuLdq1OuJRIU73YTMQR7kd9cxyV6fYyDA0ZDrdkIDbp67u8JgMWv7WRoMl0Q== X-Received: by 10.31.174.131 with SMTP id x125mr10891632vke.11.1473669596855; Mon, 12 Sep 2016 01:39:56 -0700 (PDT) MIME-Version: 1.0 Sender: sepherosa@gmail.com Received: by 10.176.69.228 with HTTP; Mon, 12 Sep 2016 01:39:54 -0700 (PDT) In-Reply-To: <20160912083228.GW38409@kib.kiev.ua> References: <201609120457.u8C4vw9S052665@repo.freebsd.org> <20160912083228.GW38409@kib.kiev.ua> From: Sepherosa Ziehau Date: Mon, 12 Sep 2016 16:39:54 +0800 X-Google-Sender-Auth: bsWlCFoAOB780G5S6vetP99ymzw Message-ID: Subject: Re: svn commit: r305722 - head/sys/x86/x86 To: Konstantin Belousov Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Sep 2016 08:39:58 -0000 On Mon, Sep 12, 2016 at 4:32 PM, Konstantin Belousov wrote: > On Mon, Sep 12, 2016 at 04:57:58AM +0000, Sepherosa Ziehau wrote: >> Author: sephe >> Date: Mon Sep 12 04:57:58 2016 >> New Revision: 305722 >> URL: https://svnweb.freebsd.org/changeset/base/305722 >> >> Log: >> x86: Use sx lock for interrupt sources. >> >> - Certain pic_assign_cpu, e.g. msi_assign_cpu can have quite a long >> call chain. For msi_assign_cpu, mutex makes complex PCI bridge >> drivers more tricky, e.g. sleep can note be called, etc, it will >> be pretty tricky for upcoming Hyper-V PCI bridge driver for PCI >> pass-through. > >> - It is not used on any hot code path nor non-sleepable context, so >> sx should have the same effect as mutex. > Did you tested ACPI_DMAR interrupt remapping mode with your patch and > witness enabled ? Nope, I am about to try it now. BTW, I just checked the code for ACPI_DMAR, I didn't see anything obviously w/ the lock type change though. Thanks, sephe -- Tomorrow Will Never Die