From owner-freebsd-current@FreeBSD.ORG Mon Oct 2 20:18:19 2006 Return-Path: X-Original-To: freebsd-current@freebsd.org Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7A2DB16A407 for ; Mon, 2 Oct 2006 20:18:19 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7939A43D8F for ; Mon, 2 Oct 2006 20:18:05 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1]) (authenticated bits=0) by server.baldwin.cx (8.13.6/8.13.6) with ESMTP id k92KHuPD019197; Mon, 2 Oct 2006 16:17:57 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: John-Mark Gurney Date: Mon, 2 Oct 2006 16:18:08 -0400 User-Agent: KMail/1.9.1 References: <20061001215643.GZ80527@funkthat.com> <200610021436.42081.jhb@freebsd.org> <20061002192659.GE80527@funkthat.com> In-Reply-To: <20061002192659.GE80527@funkthat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200610021618.09170.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]); Mon, 02 Oct 2006 16:17:57 -0400 (EDT) X-Virus-Scanned: ClamAV 0.88.3/1973/Mon Oct 2 11:18:33 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: freebsd-current@freebsd.org, "M. Warner Losh" Subject: Re: better way to build libraries.. X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Oct 2006 20:18:19 -0000 On Monday 02 October 2006 15:26, John-Mark Gurney wrote: > John Baldwin wrote this message on Mon, Oct 02, 2006 at 14:36 -0400: > > On Monday 02 October 2006 04:24, John-Mark Gurney wrote: > > > Warner Losh wrote this message on Mon, Oct 02, 2006 at 00:45 -0600: > > > > In message: <20061002014320.GA80527@funkthat.com> > > > > John-Mark Gurney writes: > > > > : I do make includes into the obj dir and use that.. (obviously you > > > > : need to review is much more closely)... > > > > > > > > I think that we're talking past each other a little, so rather than > > > > continue down that path, I'll wait for the patch to see what it does > > > > and make suggested improvements. Maybe I'll implement the glue code I > > > > was talking about too, but with a baby due any day now, maybe not. :-) > > > > > > The patch was in the original message... The one thing that I don't > > > have the make-fu to do is: a) insert the buildincs before depend (so > > > that the psuedo /usr/include is properly depended upon), and b) find > > > the correct path to tools/install.sh so install doesn't chown/grp the > > > files... > > > > > > Once a and b are solved, then it can be properly made part of > > > bsd.lib.mk... and fully evaluated upon it's merits... > > > > > > btw, my original patch is at: > > > > > http://www.freebsd.org/cgi/getmsg.cgi?fetch=722594+0+/usr/local/www/db/text/2006/freebsd-current/20061001.freebsd-current > > > > The sequence ru@ mentioned using 'make includes' is already in bsd.*.mk and > > should be sufficient for what you need. > > And also run w/ a problem that if say, the library build for some reason > failed, or something else, I end up w/ a broken /usr/include w/o any > possibility of recovery... What if I'm building this library to be run > on another box? You want me to tar up my local /usr/include, make > includes, build the library, and then restore the backed up /usr/include? No, I expect you to only use that for known-safe cases such as a small security patch and to use buildworld in all other cases. 'make buildworld NO_CLEAN=yes' for this type of update would actually be just about as quick as the sequence ru@ gave you if you leave your /usr/obj around. > All just because people object to adding a few lines to bsd.lib.mk that > will not change behavior that isn't already broken? I think bsd.*.mk are rather complex as it is. I don't think extra hacks for a few edge cases warrant the extra complexity/obfuscation. -- John Baldwin