From owner-svn-src-all@freebsd.org Tue Sep 3 14:06:33 2019 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 94886DC46B; Tue, 3 Sep 2019 14:06:09 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 46N7z46hcjz4PFb; Tue, 3 Sep 2019 14:06:08 +0000 (UTC) (envelope-from yuripv@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 1452) id 8D8081A1FD; Tue, 3 Sep 2019 14:05:59 +0000 (UTC) X-Original-To: yuripv@localmail.freebsd.org Delivered-To: yuripv@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [96.47.72.80]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 80B829E70; Thu, 4 Apr 2019 03:07:23 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2610:1c1:1:6074::16:84]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "freefall.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 32428816B0; Thu, 4 Apr 2019 03:07:23 +0000 (UTC) (envelope-from owner-src-committers@freebsd.org) Received: by freefall.freebsd.org (Postfix, from userid 538) id 22FBC9E6E; Thu, 4 Apr 2019 03:07:23 +0000 (UTC) Delivered-To: src-committers@localmail.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mx1.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by freefall.freebsd.org (Postfix) with ESMTPS id 4EEE79E6B; Thu, 4 Apr 2019 03:07:20 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pf1-x42f.google.com (mail-pf1-x42f.google.com [IPv6:2607:f8b0:4864:20::42f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C123A816AD; Thu, 4 Apr 2019 03:07:16 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pf1-x42f.google.com with SMTP id b3so602231pfd.1; Wed, 03 Apr 2019 20:07:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=fzHdg0o5n5jcpyBFnEc6DBzlDyLB8P+WHeZ11SYHiKs=; b=YhggfuNRyFBKr+o9kRCDXyZbSYLhj/XYraqR6XHFed4pUShKmtaAK3F7OhpMzscwj2 nsPOaLng8HV4IKjRRL5fnFbTjeqjMf1BD/r/GA4HZwNvjBqiQMS7DlK1kBA1nAu1qgBE R4t+sz85dnAQxkySwYoE7Qr8abk6Rsc0xZjIaPhTg1LHeIm4uCxbP4s9ylm+rtAJFmvP XawXAubno16MmWStpZfkwd/qdwlrcyL5c8UDmvukYtyrPQ0W/M3bO2LysIvkGPXH+tzw +u0tJ/VlK95LXw/s5Byy+MEf0F7Qq/mdLwtgTlKDIVSOJ9bxBnFesGI269qpZvVwstEy WdMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=fzHdg0o5n5jcpyBFnEc6DBzlDyLB8P+WHeZ11SYHiKs=; b=UnAq7l7JnV9QTRlbA8TejBpcw+IZpkSpdm1uqH3ETObvLrKWi+YJpEwS97dfu9r6Oc 46WWb76kBSy2vRT7TOomRuTQlh+sldri+fbZ3HyX4GQcA43BjIGwj9z1VgvUf6EuGoBj JYLdOTQ4TRzvZIwtO5XLGnu3hAdmHwROssFSOrrTiqmjLTMxjUNbMf7x/mx2fkbVRmYb 3YOVR33+Y4w1jRELfeOhF4hbcvwJg9Ffc+N04qsWMz2w1KOXt3Z3mY8PzKOabMkgUnBs TLmWULkImRkNNCOCKcsPcSfx0fpxDsTghMAvWWUHPmxA5T8EEA0LckrYZTY2K68xfQQc NW0w== X-Gm-Message-State: APjAAAXmsUaBiuLjIvv40yD8T0nzQOkua1SyEObFNiKAZTpFHYYsgFOv 8sdpakkABYtEH463h9MGYy3bnkQOUUo= X-Google-Smtp-Source: APXvYqyU27y+owQghRl7+lkb0D8NrYaikbf7x2VZhHQfS3ITBXYfUTztGrM2BF02FYacCj7P6up72w== X-Received: by 2002:a63:4144:: with SMTP id o65mr3119233pga.241.1554347234712; Wed, 03 Apr 2019 20:07:14 -0700 (PDT) Received: from [192.168.20.7] (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id j5sm6377559pfe.15.2019.04.03.20.07.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 03 Apr 2019 20:07:13 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.2 \(3445.102.3\)) Subject: Re: svn commit: r345860 - vendor/Juniper/libxo From: Enji Cooper In-Reply-To: <201904032230.x33MUKRn029430@repo.freebsd.org> Cc: src-committers , svn-src-all , svn-src-vendor@freebsd.org Content-Transfer-Encoding: quoted-printable Message-Id: References: <201904032230.x33MUKRn029430@repo.freebsd.org> To: Phil Shafer X-Mailer: Apple Mail (2.3445.102.3) Precedence: bulk X-Loop: FreeBSD.org Sender: owner-src-committers@freebsd.org X-Rspamd-Queue-Id: 32428816B0 X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_SHORT(-0.99)[-0.988,0]; REPLY(-4.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] Status: O X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Date: Tue, 03 Sep 2019 14:06:33 -0000 X-Original-Date: Wed, 3 Apr 2019 20:07:12 -0700 X-List-Received-Date: Tue, 03 Sep 2019 14:06:33 -0000 > On Apr 3, 2019, at 3:30 PM, Phil Shafer wrote: >=20 > Author: phil > Date: Wed Apr 3 22:30:20 2019 > New Revision: 345860 > URL: https://svnweb.freebsd.org/changeset/base/345860 >=20 > Log: > Add "MAKE=3Dgmake" to "configure" invocations in libxo import script >=20 > Modified: > vendor/Juniper/libxo/import.sh >=20 > Modified: vendor/Juniper/libxo/import.sh > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- vendor/Juniper/libxo/import.sh Wed Apr 3 21:55:39 2019 = (r345859) > +++ vendor/Juniper/libxo/import.sh Wed Apr 3 22:30:20 2019 = (r345860) > @@ -280,12 +280,12 @@ Cd $CWD/dist > run "autoreconf" "autoreconf --install --force" >=20 > Cd $CWD/dist/build > -run "configure for testing" "../configure --prefix = $CWD/dist/build/root" > +run "configure for testing" "env MAKE=3Dgmake ../configure --prefix = $CWD/dist/build/root" > run "build and test" \ > "${GMAKE} clean && ${GMAKE} && ${GMAKE} install && ${GMAKE} = test" >=20 > # Freebsd lacks stock gettext, so don't build it > -run "configure for real" "../configure --disable-gettext --prefix = /usr" > +run "configure for real" "env MAKE=3Dgmake ../configure = --disable-gettext --prefix /usr" > run "build for real" \ > "${GMAKE} clean && ${GMAKE}=E2=80=9D I could be wrong, but I=E2=80=99m guessing `GMAKE` needs to be replaced = with `MAKE`..? Also, why does a configure script need gmake? It seems like the snippets = that make libxo should be made more portable with autoconf, if that=E2=80=99= s the case. Thanks, -Enji=