Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 18 Feb 2023 17:55:04 GMT
From:      "Alexander V. Chernikov" <melifaro@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   git: 8f7455a9265f - main - netlink: fix OOB read in genetlink
Message-ID:  <202302181755.31IHt4WS083487@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch main has been updated by melifaro:

URL: https://cgit.FreeBSD.org/src/commit/?id=8f7455a9265f4952f885b06c08c57fcce6f16e5c

commit 8f7455a9265f4952f885b06c08c57fcce6f16e5c
Author:     Alexander V. Chernikov <melifaro@FreeBSD.org>
AuthorDate: 2023-02-18 17:24:59 +0000
Commit:     Alexander V. Chernikov <melifaro@FreeBSD.org>
CommitDate: 2023-02-18 17:53:06 +0000

    netlink: fix OOB read in genetlink
    
    CID:            1498863
    MFC after:      1 day
---
 sys/netlink/netlink_generic.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sys/netlink/netlink_generic.c b/sys/netlink/netlink_generic.c
index 066379e2afae..a16fdc312daa 100644
--- a/sys/netlink/netlink_generic.c
+++ b/sys/netlink/netlink_generic.c
@@ -267,7 +267,7 @@ genl_handle_message(struct nlmsghdr *hdr, struct nl_pstate *npt)
 
 	int family_id = (int)hdr->nlmsg_type - GENL_MIN_ID;
 
-	if (__predict_false(family_id < 0 || family_id > MAX_FAMILIES)) {
+	if (__predict_false(family_id < 0 || family_id >= MAX_FAMILIES)) {
 		NLP_LOG(LOG_DEBUG, nlp, "invalid message type: %d", hdr->nlmsg_type);
 		return (ENOTSUP);
 	}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202302181755.31IHt4WS083487>