From nobody Tue Jun 3 11:25:17 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bBT0F2l94z5xWFj; Tue, 03 Jun 2025 11:25:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bBT0F25D2z3gxM; Tue, 03 Jun 2025 11:25:17 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748949917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x82GnL63bY+4fOafFmHb2Dv+9qnPnKzDPqUIvZhW7kc=; b=VXscBeygg33WjjODT5GJXvzkCl5dgBUAaheYXImwklixO29K+3szUNgaN28GWJ5/fBuCJz lm4jA2/1QeZY+i2MFJGX/ke8poswNPfIqUD6GkaN4F4PHxlMPsqj/CWDETqT0YABv/3tjx R2TZuXiACYwl4FkJWU9rhhx+2OS5LCDbBKuG27ZqEEJVcM7Z8M5SSJzbEpMcidG3ljtPGh GO5BLCWHXMvR5lgcbqUEduUUGFHiXiWOE/hWqikyfxp8YLD2n4pWcjGzS3KBhfjjXOKfgD fcHWr11Hu0YNyC05bEdLHoC+AwKY+yczAVn+3bssJahuZeXJ7gO9XnS8OU+bgA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1748949917; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=x82GnL63bY+4fOafFmHb2Dv+9qnPnKzDPqUIvZhW7kc=; b=foyNFNk9ZKUZQpFoqjPj3mnJFN/6x7pXL3OUDFMa1JQYX6erOLlEGz4g2hbCcQI031bhLB PkFUpXt47X5loRH1mcwPngin37Y8IJq3N8WHno4Ij8VjlK5QOqTuK14Ql9jWoz0Ii65tPN g1T6dGInNjCSWQaLwEgw60cjX8zWdGqggKM/h/dwLj9IGTs6HKsiEO6GI2yzc3XoH6G/8R O080ZcQGx5WZiSr/7DJK4wfF/79AprzBoLlm2Fg8r4ySxnl5UlISu7u+eqRhMbTBzCM4Qe QxQBmhuZKynnsLwytc+KY7MxAFe4+4L/YpTTzrGMtxguOS9vj7iNeycotMfX/Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1748949917; a=rsa-sha256; cv=none; b=Jz9KQfQg+ssTnspYExDJfoTw3MtvuM4rBxAuMNRl6NJqY2S6IB6rfq3RCrIKxjEsSZ/kUZ S6D9ta898La0kb98Sh8V5Odd09T+XLPE0bcuy+6vOiB/0NwCw69EMhyImSpq0Mp5/KblWj DyhcK+qFZT8J2WYHTIW4pb9i/OH0PwTDNprFgxu6+OqfBkZJVGKjgFCqR9CLOxZTt+F9sM 8VOUsRYttPx/nJFrTcKdSfWrh6o8eE0RWpXBlMP5vgNM+BIvwoEXmwdROZtJyjKNHLRp7u L0meR814tKiSEItf0y1DiLjyWFR+EQJzwNk28Sg2ie21B5yurS2KsvFPL+YzmA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bBT0F1D0Kzcy2; Tue, 03 Jun 2025 11:25:17 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 553BPHfZ094139; Tue, 3 Jun 2025 11:25:17 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 553BPHor094136; Tue, 3 Jun 2025 11:25:17 GMT (envelope-from git) Date: Tue, 3 Jun 2025 11:25:17 GMT Message-Id: <202506031125.553BPHor094136@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 9a139facd06e - main - pseudofs: enhance KASSERT with more information List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 9a139facd06e4a1159a9c2cb992d04bcf1079e7e Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=9a139facd06e4a1159a9c2cb992d04bcf1079e7e commit 9a139facd06e4a1159a9c2cb992d04bcf1079e7e Author: Bjoern A. Zeeb AuthorDate: 2025-06-03 11:20:56 +0000 Commit: Bjoern A. Zeeb CommitDate: 2025-06-03 11:25:00 +0000 pseudofs: enhance KASSERT with more information Add the name and type information to a KASSERT for 'homonymous siblings'. Without this (or a core file) we do not even know which entry to look for. This should make reporting and debugging a tad more simple. Prompted by: PR 287165 --- sys/fs/pseudofs/pseudofs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sys/fs/pseudofs/pseudofs.c b/sys/fs/pseudofs/pseudofs.c index eb4ca8a82456..d8dbf7117d13 100644 --- a/sys/fs/pseudofs/pseudofs.c +++ b/sys/fs/pseudofs/pseudofs.c @@ -124,7 +124,8 @@ pfs_add_node(struct pfs_node *parent, struct pfs_node *pn) ("%s(): nested process directories", __func__)); for (iter = parent->pn_nodes; iter != NULL; iter = iter->pn_next) { KASSERT(strcmp(pn->pn_name, iter->pn_name) != 0, - ("%s(): homonymous siblings", __func__)); + ("%s(): homonymous siblings: '%s' type %d", __func__, + pn->pn_name, pn->pn_type)); if (pn->pn_type == pfstype_procdir) KASSERT(iter->pn_type != pfstype_procdir, ("%s(): sibling process directories", __func__));