From owner-svn-src-all@freebsd.org Sun Dec 18 16:37:58 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 52E9AC875AA for ; Sun, 18 Dec 2016 16:37:58 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: from mail-yb0-x236.google.com (mail-yb0-x236.google.com [IPv6:2607:f8b0:4002:c09::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1CCAA1475 for ; Sun, 18 Dec 2016 16:37:57 +0000 (UTC) (envelope-from ed@nuxi.nl) Received: by mail-yb0-x236.google.com with SMTP id d128so51636802ybh.2 for ; Sun, 18 Dec 2016 08:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuxi-nl.20150623.gappssmtp.com; s=20150623; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=V9VPVfZ2/rS2BlPLwsEc2Kj12IW23+dGaopDD6ExIJU=; b=DfzHuFIj5hOE/Xpcd1O/oeRFEB2KuwHWzf7tJ8BOukxYzWF1n785kVDxaO2denZxEA 2C3K/6M1UjbPvV9N3n4mUoD/fOQz9cawuNrXoBYPnv5tNsyQHBsicUSn+g8xqcwmRPeo 9dZTLeBEibccE3n7cScDkZzNGZmcQh6ZRJO+yb03Nbqf/4AyJD1+EG5nYerqkAbJAz7i c7Shcu08GMw254twkXaQ9ME/9dkZImnEnFRP61WBDbTGfhnYDWMMgIzpADOHuE/Ei2M4 gdzd6uC713EXk70thYTvdvDOuGixtJ1FDg38GucD7yxkXi1vunTHEjvbNFjVe4cC22r1 EQBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=V9VPVfZ2/rS2BlPLwsEc2Kj12IW23+dGaopDD6ExIJU=; b=LQXRU8sL7MA0GQKiSYFCjlo9GrPlhD+BoitUqASleZhxmfa+qbyZAejiciEa8EGT8g QxjDtv0LDHiZ+XOqZcygaVgsF272u8CySgoQ/fGiCjbizeV39zVx5rFfHP9YB4YbVqiB SPjrlXHWmCuaAQQyjyTEwpwBCz8xxmh+Iu/DOV7mQJ4c4PKhshHqBU5Xs6zsZwGmRSc9 Q0KiEigW9lFjcAz6xvqed9VyTsVRrMMXganGtH8A7sisfmAqdF1gl9Njm8gpbcLnw3/Q YenJ3op0fA/omkuoydCg1g0OLiYr8rk4/zZHqz00BP8nR/Rv68TeZae2/5uHwNPzTGg5 QRdw== X-Gm-Message-State: AIkVDXJTIwvvyqjW+t8iBw5gq9zqTjGcSl2UrUp7dPmF0OYQP7PReSG63kqMu0WNc4LM+6tsJmR14ZaTvdvPAg== X-Received: by 10.37.163.33 with SMTP id d30mr2300ybi.54.1482079077048; Sun, 18 Dec 2016 08:37:57 -0800 (PST) MIME-Version: 1.0 Received: by 10.129.2.139 with HTTP; Sun, 18 Dec 2016 08:37:26 -0800 (PST) In-Reply-To: <201612181521.uBIFLcB3030383@repo.freebsd.org> References: <201612181521.uBIFLcB3030383@repo.freebsd.org> From: Ed Schouten Date: Sun, 18 Dec 2016 17:37:26 +0100 Message-ID: Subject: Re: svn commit: r310232 - head/sys/dev/mlx4/mlx4_ib To: Dimitry Andric Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 18 Dec 2016 16:37:58 -0000 2016-12-18 16:21 GMT+01:00 Dimitry Andric : > Modified: head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c > ============================================================================== > --- head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c Sun Dec 18 15:10:08 2016 (r310231) > +++ head/sys/dev/mlx4/mlx4_ib/mlx4_ib_sysfs.c Sun Dec 18 15:21:38 2016 (r310232) > @@ -79,7 +79,7 @@ static ssize_t store_admin_alias_guid(st > container_of(attr, struct mlx4_ib_iov_sysfs_attr, dentry); > struct mlx4_ib_iov_port *port = mlx4_ib_iov_dentry->ctx; > struct mlx4_ib_dev *mdev = port->dev; > - u64 sysadmin_ag_val; > + unsigned long long sysadmin_ag_val; > > record_num = mlx4_ib_iov_dentry->entry_num / 8; > guid_index_in_rec = mlx4_ib_iov_dentry->entry_num % 8; Looking at the code, the intent is that an actual 64-bit integer is parsed; not an unsigned long long. What's wrong with using inttypes.h's SCNx64? -- Ed Schouten Nuxi, 's-Hertogenbosch, the Netherlands KvK-nr.: 62051717