From owner-cvs-all Tue Oct 3 4:49:16 2000 Delivered-To: cvs-all@freebsd.org Received: from sin.cc.kogakuin.ac.jp (sin.cc.kogakuin.ac.jp [133.80.128.5]) by hub.freebsd.org (Postfix) with ESMTP id 17A2937B503; Tue, 3 Oct 2000 04:49:11 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by sin.cc.kogakuin.ac.jp (8.8.8/3.7W00071916) with ESMTP id UAA06803; Tue, 3 Oct 2000 20:48:57 +0900 (JST) To: winter@jurai.net Cc: nyan@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/release/sysinstall devices.c src/sys/conf files.pc98 src/sys/dev/snc dp83932.c dp83932reg.h dp83932subr.c dp83932subr.h dp83932var.h if_snc.c if_snc_cbus.c if_snc_pccard.c if_sncreg.h if_sncvar.h src/sys/modules Makefile ... From: Takahashi Yoshihiro In-Reply-To: References: <200010021427.HAA16733@freefall.freebsd.org> X-Mailer: Mew version 1.94.1 on Emacs 19.34 / Mule 2.3 (SUETSUMUHANA) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-Id: <20001003204856T.nyan@cc.kogakuin.ac.jp> Date: Tue, 03 Oct 2000 20:48:56 +0900 (JST) X-Dispatcher: imput version 990905(IM130) Lines: 17 Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In article "Matthew N. Dodd" writes: > if_sn.c:snc_alloc_{port,memory,irq}() all need fixing in their handling of > the failure case of bus_alloc_resource(). You can't rely on > bus_get_resource()/bus_get_resource_start() to do the right thing if > bus_alloc_resource() has already failed. You -must- check the return of > bus_get_resource()/bus_get_resource_start(). > > I'd suggest punting as the failure case only prints out a cosmetic "this > didn't work" message. OK, I'd fixed. --- Takahashi Yoshihiro The Center for Information Science, Kogakuin Univ. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message