From owner-freebsd-current@FreeBSD.ORG  Wed Sep  8 17:01:31 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id AED8F1065694;
	Wed,  8 Sep 2010 17:01:31 +0000 (UTC)
	(envelope-from phk@critter.freebsd.dk)
Received: from phk.freebsd.dk (phk.freebsd.dk [130.225.244.222])
	by mx1.freebsd.org (Postfix) with ESMTP id 7430C8FC0C;
	Wed,  8 Sep 2010 17:01:31 +0000 (UTC)
Received: from critter.freebsd.dk (critter.freebsd.dk [192.168.61.3])
	by phk.freebsd.dk (Postfix) with ESMTP id 6FB403F592;
	Wed,  8 Sep 2010 17:01:30 +0000 (UTC)
Received: from critter.freebsd.dk (localhost [127.0.0.1])
	by critter.freebsd.dk (8.14.4/8.14.4) with ESMTP id o88H1Uck067331;
	Wed, 8 Sep 2010 17:01:30 GMT (envelope-from phk@critter.freebsd.dk)
To: Ryan Stone <rysto32@gmail.com>
From: "Poul-Henning Kamp" <phk@phk.freebsd.dk>
In-Reply-To: Your message of "Wed, 08 Sep 2010 12:47:41 -0400."
	<AANLkTin9WoQZxMc8U9MWPk3=OPTY0yzFYMTA68aYno2_@mail.gmail.com> 
Date: Wed, 08 Sep 2010 17:01:30 +0000
Message-ID: <67330.1283965290@critter.freebsd.dk>
Sender: phk@critter.freebsd.dk
Cc: mdf@freebsd.org, freebsd-current@freebsd.org
Subject: Re: deprecating sprintf(9) 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 08 Sep 2010 17:01:31 -0000

In message <AANLkTin9WoQZxMc8U9MWPk3=OPTY0yzFYMTA68aYno2_@mail.gmail.com>, Ryan
 Stone writes:

>> #define bprintf(buf, fmt, ...)                                          \
>>        do {                                                            \
>>                assert(snprintf(buf, sizeof buf, fmt, __VA_ARGS__)      \
>>                    < sizeof buf);                                      \
>>        } while (0)
>
>Anyone using this macro is in for a nasty surprise when they compile
>with -DNDEBUG.

First, I think they will figure out pretty fast that it is a bad idea.

Second, -DNDEBUG has always been and still is a mistake.

That is why we have an explicit DIAGNOSTIC for the kernel.

Poul-Henning

-- 
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD committer       | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.