From owner-dev-commits-src-main@freebsd.org Mon Aug 2 06:26:52 2021 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id DBC6566E2C9; Mon, 2 Aug 2021 06:26:52 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (turbocat.net [IPv6:2a01:4f8:c17:6c4b::2]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4GdShX4hZ4z4tl1; Mon, 2 Aug 2021 06:26:52 +0000 (UTC) (envelope-from hps@selasky.org) Received: from hps2020.home.selasky.org (unknown [178.17.145.105]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 2EC932600CB; Mon, 2 Aug 2021 08:26:44 +0200 (CEST) Subject: Re: git: 469884cf04a9 - main - LinuxKPI: Make FPU sections thread-safe and use the NOCTX flag. To: Charlie Li , src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202107311338.16VDcaSh006994@gitrepo.freebsd.org> From: Hans Petter Selasky Message-ID: Date: Mon, 2 Aug 2021 08:26:33 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 4GdShX4hZ4z4tl1 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for the main branch of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Aug 2021 06:26:52 -0000 On 8/1/21 12:32 PM, Charlie Li wrote: > Hans Petter Selasky wrote: >> commit 469884cf04a9b92677c7c83e229ca6b8814f8b0a >> Author: Hans Petter Selasky >> AuthorDate: 2021-07-31 13:32:52 +0000 >> Commit: Hans Petter Selasky >> CommitDate: 2021-07-31 13:36:48 +0000 >> >> LinuxKPI: Make FPU sections thread-safe and use the NOCTX flag. >> >> Reviewed by: kib >> Submitted by: greg@unrelenting.technology >> Differential Revision: https://reviews.freebsd.org/D29921 >> MFC after: 1 week >> Sponsored by: NVIDIA Networking >> --- >> sys/compat/linuxkpi/common/include/asm/fpu/api.h | 40 ++++------------------ >> sys/compat/linuxkpi/common/include/linux/sched.h | 3 +- >> sys/compat/linuxkpi/common/src/linux_fpu.c | 43 ++++++++++++++++++------ >> sys/conf/files.amd64 | 3 -- >> sys/conf/files.arm64 | 4 --- >> sys/conf/files.i386 | 3 -- >> sys/modules/linuxkpi/Makefile | 3 +- >> 7 files changed, 43 insertions(+), 56 deletions(-) >> > i915kms from drm-kmod, while successfully built against the commit after > (__FreeBSD_version bump), fails to load on that same commit: > > link_elf_obj: symbol lkpi_kernel_fpu_begin undefined > linker_load_file: /boot/modules/i915kms.ko - unsupported file type > Should be fixed by: https://cgit.freebsd.org/src/commit/?id=9340ebd404efad7068b5a45fd3b3d8bb21187b91 --HPS