From owner-freebsd-arm@FreeBSD.ORG  Sun Aug 19 16:25:08 2012
Return-Path: <owner-freebsd-arm@FreeBSD.ORG>
Delivered-To: freebsd-arm@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 2A5441065672;
	Sun, 19 Aug 2012 16:25:08 +0000 (UTC)
	(envelope-from tim@kientzle.com)
Received: from monday.kientzle.com (99-115-135-74.uvs.sntcca.sbcglobal.net
	[99.115.135.74])
	by mx1.freebsd.org (Postfix) with ESMTP id 13F1D8FC08;
	Sun, 19 Aug 2012 16:25:06 +0000 (UTC)
Received: (from root@localhost)
	by monday.kientzle.com (8.14.4/8.14.4) id q7JG3CcY044828;
	Sun, 19 Aug 2012 16:03:12 GMT (envelope-from tim@kientzle.com)
Received: from [192.168.2.143] (CiscoE3000 [192.168.1.65])
	by kientzle.com with SMTP id ij4p954sthnpfqmj9fqsfpcs5n;
	Sun, 19 Aug 2012 16:03:12 +0000 (UTC)
	(envelope-from tim@kientzle.com)
Mime-Version: 1.0 (Apple Message framework v1278)
Content-Type: text/plain; charset=us-ascii
From: Tim Kientzle <tim@kientzle.com>
In-Reply-To: <8CDAB51C-14A0-42F0-8E16-43A3EABA2703@bsdimp.com>
Date: Sun, 19 Aug 2012 09:03:11 -0700
Content-Transfer-Encoding: quoted-printable
Message-Id: <E7C5ED5C-7120-4B69-9146-D9CC7A8E14C2@kientzle.com>
References: <20120819.171723.523519054460575158.hrs@allbsd.org>
	<8CDAB51C-14A0-42F0-8E16-43A3EABA2703@bsdimp.com>
To: Warner Losh <imp@bsdimp.com>
X-Mailer: Apple Mail (2.1278)
Cc: gonzo@freebsd.org, freebsd-arm@freebsd.org
Subject: Re: gpiobus_hinted_child >32 pins support, pin_getname method,
	and gpio-sysctl bridge patch
X-BeenThere: freebsd-arm@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Porting FreeBSD to the StrongARM Processor <freebsd-arm.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-arm>
List-Post: <mailto:freebsd-arm@freebsd.org>
List-Help: <mailto:freebsd-arm-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-arm>,
	<mailto:freebsd-arm-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 19 Aug 2012 16:25:08 -0000

On Aug 19, 2012, at 8:38 AM, Warner Losh wrote:

>=20
> In general, I like this code in the context of the current GPIO =
framework.  I've been growing dissatisfied with the current GPIO =
framework, however, and some of my comments reflect that more than any =
comments about this specific code.

I noticed that Linux on BeagleBone does not
simply number all pins as we do.  Pins are identified by
two numbers:  a unit number and a pin number.

The AM3358 SoC has a couple of GPIO modules,
so this makes it pretty natural to map hardware
diagrams (which refer to "pin 13 of GPIO module 1") to
software.=20

I agree with Warner that masks are probably a bad
idea at the framework level.

But this all may have to wait for "gpioNG".

Tim