From nobody Tue Sep 28 23:53:28 2021 X-Original-To: net@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 55B8117E5A79 for ; Tue, 28 Sep 2021 23:53:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4HJxCs0pG6z3MgC for ; Tue, 28 Sep 2021 23:53:29 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id F112F5E13 for ; Tue, 28 Sep 2021 23:53:28 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 18SNrSIC082023 for ; Tue, 28 Sep 2021 23:53:28 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 18SNrSb1082022 for net@FreeBSD.org; Tue, 28 Sep 2021 23:53:28 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: net@FreeBSD.org Subject: [Bug 230996] em/igb: Intel i210/i350: ifconfig: enabling "vlanhwtag" renders VLAN on i210/i350 NICs unusable Date: Tue, 28 Sep 2021 23:53:28 +0000 X-Bugzilla-Reason: CC AssignedTo X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: kern X-Bugzilla-Version: 12.0-RELEASE X-Bugzilla-Keywords: IntelNetworking, needs-qa, performance, regression X-Bugzilla-Severity: Affects Many People X-Bugzilla-Who: jason@tubnor.net X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: Normal X-Bugzilla-Assigned-To: net@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? mfc-stable12? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated List-Id: Networking and TCP/IP with FreeBSD List-Archive: https://lists.freebsd.org/archives/freebsd-net List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-freebsd-net@freebsd.org MIME-Version: 1.0 X-ThisMailContainsUnwantedMimeParts: N https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D230996 --- Comment #42 from Jason Tubnor --- I have added a comment to the review. I received an undeclared identifier: /usr/src/sys/dev/e1000/if_em.c:3329:28: error: use of undeclared identifier 'pszie'; did you mean 'psize'? e1000_rlpml_set_vf(hw, pszie); ^~~~~ psize /usr/src/sys/dev/e1000/if_em.c:3320:7: note: 'psize' declared here u32 psize, srrctl =3D 0; ^ 1 error generated. *** Error code 1 Stop. --- Changed the above to psize and all built and runs ok. Looking at the commit, this was fixed between revision and commit. Testing on stacked VLAN igb interfaces works as intended on 13-STABLE-20210= 923 without removing any interface options (was working fine before the patch),= so no regression with existing systems. Also tested where VLANs were added to bridges and bhyve guest taps added to the bridge and no performance regress= ions were identified on the guests or hosts. Not tested with 12-stable. --=20 You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug.=