From owner-cvs-src@FreeBSD.ORG Tue Mar 30 12:27:48 2004 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 72D3916A4CE; Tue, 30 Mar 2004 12:27:48 -0800 (PST) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id AF21643D2D; Tue, 30 Mar 2004 12:27:47 -0800 (PST) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.11/8.12.11) with ESMTP id i2UKRkFa003736; Wed, 31 Mar 2004 00:27:46 +0400 (MSD) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.11/8.12.11/Submit) id i2UKRjgY003735; Wed, 31 Mar 2004 00:27:45 +0400 (MSD) (envelope-from ache) Date: Wed, 31 Mar 2004 00:27:44 +0400 From: Andrey Chernov To: "Brian F. Feldman" Message-ID: <20040330202743.GA3407@nagual.pp.ru> Mail-Followup-To: Andrey Chernov , "Brian F. Feldman" , Dag-Erling Smorgrav , src-committers@FreeBSD.ORG, cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG References: <20040330155233.GA71146@nagual.pp.ru> <200403301627.i2UGRx9q030892@green.homeunix.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200403301627.i2UGRx9q030892@green.homeunix.org> User-Agent: Mutt/1.5.6i X-AntiVirus: checked by AntiVir Milter 1.1-beta; AVE 6.24.0.7; VDF 6.24.0.76 (host: pobrecita.freebsd.ru) cc: cvs-src@FreeBSD.ORG cc: src-committers@FreeBSD.ORG cc: cvs-all@FreeBSD.ORG cc: Dag-Erling Smorgrav Subject: Re: cvs commit: src/etc/mtree BSD.local.dist BSD.usr.dist X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2004 20:27:48 -0000 On Tue, Mar 30, 2004 at 11:27:58AM -0500, Brian F. Feldman wrote: > Okay, now I understand what the situation is that would make this not work > well. Why not just warn and ignore it, then? Warnings can be too verbose, in case too many dirs affected, so they can hide real errors. In opposite situation, i.e. no warnings at all, some errors could be skipped. So this thing needs a proper fix, not just a workaround. > The proper fix would be to > resolve, at the end of reading the mtree spec file, any type=link (when -L) > and fail if they cannot be dereferenced internally. It can be kinda of two-passes mode, if -L is specified: 1st pass checks everything excepting type=link, in -L mode 2nd pass checks type=link only, in -P mode And remember that both workaround and proper fix will make us very different from any other *BSD. -- Andrey Chernov | http://ache.pp.ru/