From owner-svn-ports-all@freebsd.org  Fri Sep 14 14:39:50 2018
Return-Path: <owner-svn-ports-all@freebsd.org>
Delivered-To: svn-ports-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 1406C108A509;
 Fri, 14 Sep 2018 14:39:50 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id B7F9D84464;
 Fri, 14 Sep 2018 14:39:49 +0000 (UTC)
 (envelope-from jbeich@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1354)
 id 956001FB2D; Fri, 14 Sep 2018 14:39:49 +0000 (UTC)
From: Jan Beich <jbeich@FreeBSD.org>
To: Mathieu Arnold <mat@FreeBSD.org>
Cc: Yuri Victorovich <yuri@FreeBSD.org>,
 svn-ports-head@freebsd.org, svn-ports-all@freebsd.org,
 ports-committers@freebsd.org
Subject: Re: svn commit: r479762 - head/science/cp2k
References: <201809140758.w8E7w5D9093846@repo.freebsd.org>
 <20180914102558.e4tuqrxeu7jvyyu4@atuin.in.mat.cc>
Date: Fri, 14 Sep 2018 16:39:27 +0200
In-Reply-To: <20180914102558.e4tuqrxeu7jvyyu4@atuin.in.mat.cc> (Mathieu
 Arnold's message of "Fri, 14 Sep 2018 12:25:58 +0200")
Message-ID: <lg84-qh28-wny@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: svn-ports-all@freebsd.org
X-Mailman-Version: 2.1.27
Precedence: list
List-Id: SVN commit messages for the ports tree <svn-ports-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-all/>
List-Post: <mailto:svn-ports-all@freebsd.org>
List-Help: <mailto:svn-ports-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-all>,
 <mailto:svn-ports-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Fri, 14 Sep 2018 14:39:50 -0000

Mathieu Arnold <mat@FreeBSD.org> writes:

> On Fri, Sep 14, 2018 at 07:58:05AM +0000, Yuri Victorovich wrote:
>
>> +.include <bsd.port.options.mk>
>> +
>> +.if ${PORT_OPTIONS:MOPENMP} || ${PORT_OPTIONS:MOPENMP_MPI}
>> +pre-configure:
>> +	@if [ ! -e ${LOCALBASE}/lib/libfftw3_omp.so ] ; then \
>> +	  ${ECHO_MSG} "The OPENMP and OPENMP_MPI options require math/fftw3" ; \
>> +	  ${ECHO_MSG} "to be built and installed with the OPENMP option ON" ; \
>> +	  exit 1; \
>> +	fi
>> +.endif
>
> I keep wondering why you always try so hard to invent new ways of doing
> things.
>
> .if ${PORT_OPTIONS:MOPENMP} || ${PORT_OPTIONS:MOPENMP_MPI}
> . if !exists(${LOCALBASE}/lib/libfftw3_omp.so)
> BROKEN=	The OPENMP and OPENMP_MPI options require math/fftw3 to be built and installed with the OPENMP option ON
> . endif
> .endif

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=166279 for an
example where your approach fails.