From owner-svn-src-vendor@freebsd.org Thu Oct 15 15:48:56 2015 Return-Path: Delivered-To: svn-src-vendor@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id EC7CFA1588E; Thu, 15 Oct 2015 15:48:55 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-lf0-x22f.google.com (mail-lf0-x22f.google.com [IPv6:2a00:1450:4010:c07::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 6E0262AA; Thu, 15 Oct 2015 15:48:55 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: by lfeh64 with SMTP id h64so32734632lfe.3; Thu, 15 Oct 2015 08:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=/MmDOb0XE/onoZsRyjwrB80KsCDRsESvN4IKf5SpkQk=; b=dmcs7avlMzVfsv6jNtfVqZ9UMV2SeaQ+7vLt4RgY3HrZu5Km5rlNBeE9ya3XUkv0qQ 2QLbWTESokbLGOhH6jvkR1yH1ceD2fwdRAPzx8uyd62KIGsib1RLVe/zV7/SGS8TUan2 7coOilBQXfRliieq2eWTEdMafq18hUAf7unhF5dd55MtDWW4xWr7L9fbNfTt6B+7FZWP fNszSU2AAeIZcT7Ds2QbvwZr1/2p5aJPj0XLeMqJxsis/bFJa/WARXJThBCkYg9tpt/y wQOcBJkf6vICBq+xhQhiM2SlFr5mfsuoNJ5fYsh0GYXwexKo0vz0bpZf6ly/i4eEiuDW xvig== X-Received: by 10.180.20.1 with SMTP id j1mr27954638wie.78.1444924131751; Thu, 15 Oct 2015 08:48:51 -0700 (PDT) Received: from mavbook.mavhome.dp.ua ([2a01:d0:c0a9:3:c685:8ff:fe11:1aa2]) by smtp.googlemail.com with ESMTPSA id xa5sm17196280wjc.20.2015.10.15.08.48.50 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Oct 2015 08:48:51 -0700 (PDT) Sender: Alexander Motin Message-ID: <561FCAE1.1040504@FreeBSD.org> Date: Thu, 15 Oct 2015 18:48:49 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Andriy Gapon , src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-vendor@FreeBSD.org Subject: Re: svn commit: r289310 - vendor-sys/illumos/dist/common/zfs vendor-sys/illumos/dist/uts/common vendor-sys/illumos/dist/uts/common/crypto vendor-sys/illumos/dist/uts/common/crypto/io vendor-sys/illumos... References: <201510141112.t9EBCmFZ022230@repo.freebsd.org> <561FC5A0.3040909@FreeBSD.org> <561FC90F.4090706@FreeBSD.org> <561FC996.3020207@FreeBSD.org> In-Reply-To: <561FC996.3020207@FreeBSD.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-vendor@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the vendor work area tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Oct 2015 15:48:56 -0000 On 15.10.2015 18:43, Andriy Gapon wrote: > On 15/10/2015 17:41, Alexander Motin wrote: >> On 15.10.2015 18:26, Andriy Gapon wrote: >>> On 14/10/2015 13:12, Alexander Motin wrote: >>>> Author: mav >>>> Date: Wed Oct 14 11:12:47 2015 >>>> New Revision: 289310 >>>> URL: https://svnweb.freebsd.org/changeset/base/289310 >>>> >>>> Log: >>>> 4185 add new cryptographic checksums to ZFS: SHA-512, Skein, Edon-R >>>> >>>> Reviewed by: George Wilson >>>> Reviewed by: Prakash Surya >>>> Reviewed by: Saso Kiselkov >>>> Reviewed by: Richard Lowe >>>> Approved by: Garrett D'Amore >>>> Author: Matthew Ahrens >>>> >>>> illumos/illumos-gate@45818ee124adeaaf947698996b4f4c722afc6d1f >>>> >>>> Added: >>>> vendor/illumos/dist/common/crypto/ >>>> vendor/illumos/dist/common/crypto/edonr/ >>>> vendor/illumos/dist/common/crypto/edonr/edonr.c (contents, props changed) >>>> vendor/illumos/dist/common/crypto/edonr/edonr_byteorder.h (contents, props changed) >>>> vendor/illumos/dist/common/crypto/skein/ >>>> vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE (contents, props changed) >>>> vendor/illumos/dist/common/crypto/skein/THIRDPARTYLICENSE.descrip (contents, props changed) >>>> vendor/illumos/dist/common/crypto/skein/skein.c (contents, props changed) >>>> vendor/illumos/dist/common/crypto/skein/skein_block.c (contents, props changed) >>>> vendor/illumos/dist/common/crypto/skein/skein_impl.h (contents, props changed) >>>> vendor/illumos/dist/common/crypto/skein/skein_iv.c (contents, props changed) >>>> vendor/illumos/dist/common/crypto/skein/skein_port.h (contents, props changed) >>> >>> It seems that these are pieces of code that can be used by both the >>> userland and the kernel. I think that previously we used to import such >>> code into illumos-sys and then integrate it into sys/cddl (e.g. >>> common/zfs/). Perhaps it is worthwhile following that convention in >>> this case as well? >> >> I haven't decided what to do with this specific case. As I understand, >> now we are using FreeBSD's native crypto code instead of illumos' one. I >> was thinking about importing this commit only in infrastructural parts, >> until respective algorithms are implemented in our native crypto. I >> think it should not be a problem for Skein, since according to comments >> it is in public domain. About Edon-R I am not sure, since it seems to be >> CDDL. > > This is confusing... It seems that like you replied to my question in > another email, not the quoted one :-) What other email? You've told me that I put code into the wrong place, and I replied that it may be irrelevant, since I am not sure we should import this code to FreeBSD as-is to its place in illumos. -- Alexander Motin