From owner-svn-src-all@FreeBSD.ORG Thu Jan 1 07:08:09 2009 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47569106564A; Thu, 1 Jan 2009 07:08:09 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id 05BBD8FC13; Thu, 1 Jan 2009 07:08:08 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n0176Tq4028568; Thu, 1 Jan 2009 00:06:30 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Thu, 01 Jan 2009 00:06:43 -0700 (MST) Message-Id: <20090101.000643.1543764949.imp@bsdimp.com> To: rik@inse.ru From: "M. Warner Losh" In-Reply-To: <495B406F.2040305@localhost.inse.ru> References: <200812271522.mBRFMMHY074982@svn.freebsd.org> <20081229.114241.756909212.imp@bsdimp.com> <495B406F.2040305@localhost.inse.ru> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: rik@FreeBSD.org, svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r186520 - head/sys/dev/puc X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Jan 2009 07:08:09 -0000 In message: <495B406F.2040305@localhost.inse.ru> Roman Kurakin writes: : M. Warner Losh wrote: : > In message: <200812271522.mBRFMMHY074982@svn.freebsd.org> : > Roman Kurakin writes: : > : Author: rik : > : Date: Sat Dec 27 15:22:22 2008 : > : New Revision: 186520 : > : URL: http://svn.freebsd.org/changeset/base/186520 : > : : > : Log: : > : Add support for the Oxford OX16PCI958-based card. : > : : > : Note, that the patch provided with this card for the Linux states that : > : the card uses DEFAULT_RCLK * 2, while in fact it is '* 10'. So probably : > : we should also use the subdevice/subvendord here. For now just ignore : > : that fact. : > : > I've had problems with doing that on some Oxford based cards. The : > vendor that uses them doesn't set them up, so you can't tell my : > cardbus oxford card from the pcie oxford card that someone else sent : > me patches for: both with different clock multipliers... : > : Probably we need to implement AUTODETECT_RCLK. I've had the patch, : but it worked only for modules, cause there was no working timers while the : cards probe time if the driver was compiled in. I've planned to move : detection : code to the first open and do some cleanup after the detection, but : didn't do : that. I'd like to see that. I think we can defer the detection of RCLK to later. How accurate is this, btw? How dependent on timing of interrupts is it? Warner