From owner-svn-src-head@FreeBSD.ORG Mon Oct 27 17:40:24 2014 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 0EB5C3EB; Mon, 27 Oct 2014 17:40:24 +0000 (UTC) Received: from f10.opsec.eu (f10.opsec.eu [IPv6:2001:14f8:200:4::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id BA354931; Mon, 27 Oct 2014 17:40:23 +0000 (UTC) Received: from pi by f10.opsec.eu with local (Exim 4.84 (FreeBSD)) (envelope-from ) id 1XioHC-0003tP-Lw; Mon, 27 Oct 2014 18:40:18 +0100 Date: Mon, 27 Oct 2014 18:40:18 +0100 From: Kurt Jaeger To: Bruce Evans Subject: Re: svn commit: r273734 - head/bin/dd Message-ID: <20141027174018.GQ1492@f10.opsec.eu> References: <201410271138.s9RBcHrA002447@svn.freebsd.org> <20141028005225.S2013@besplex.bde.org> <20141027162034.GN1492@f10.opsec.eu> <20141028040638.O3114@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141028040638.O3114@besplex.bde.org> Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, Kurt Jaeger X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Oct 2014 17:40:24 -0000 Hi! > > So, given this detailed review, should I revert the change ? > > Yes. You would have to change half of it just to get it to compile > on 32-bit arches. Done. It's clearly my fault, I was sloppy in testing 8-( -- pi@FreeBSD.org +49 171 3101372 6 years to go !