From owner-freebsd-wireless@FreeBSD.ORG  Tue Apr 19 10:47:25 2011
Return-Path: <owner-freebsd-wireless@FreeBSD.ORG>
Delivered-To: freebsd-wireless@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 188441065673
	for <freebsd-wireless@freebsd.org>;
	Tue, 19 Apr 2011 10:47:25 +0000 (UTC)
	(envelope-from adrian.chadd@gmail.com)
Received: from mail-ww0-f50.google.com (mail-ww0-f50.google.com [74.125.82.50])
	by mx1.freebsd.org (Postfix) with ESMTP id 9D4738FC16
	for <freebsd-wireless@freebsd.org>;
	Tue, 19 Apr 2011 10:47:23 +0000 (UTC)
Received: by wwc33 with SMTP id 33so6655920wwc.31
	for <freebsd-wireless@freebsd.org>;
	Tue, 19 Apr 2011 03:47:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
	h=domainkey-signature:mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	bh=Khsixi9H8xcx9wTTZS2MXOr9p8JQsAHi5xey+PxB6oA=;
	b=ET2HT+44QQjNRtITYDiL8Hw4Qh0ubS7V5F0KFMIHgYJNSInSAfOQdG6BAlLPSzSE4g
	bx4FN77hhIxoxCjPP22Cek2pc0Y+cIlGZIwhE+wOtFRyHekelp2czxuCzhmj6fVEAI/G
	Istayie03h97oTfe/3wm/EQf9LFKskJ3nfz0g=
DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
	h=mime-version:sender:in-reply-to:references:date
	:x-google-sender-auth:message-id:subject:from:to:cc:content-type;
	b=tiK5fakVBRbwjztnK7Q6CCjpeNcmUJmW7jX28i0Z7sF+nPReHswbjbsCf9ngm6hpZv
	RwVEraew4dHQlNeImBjftfmlMfBg/DkKr7xK3xNX1fLjZAps3nYjgIvUZIo65P9pOL8V
	vXhiZyYeGHC/pS6f0GFBUe9MCNOjjyQLdEt4M=
MIME-Version: 1.0
Received: by 10.227.210.131 with SMTP id gk3mr6206082wbb.140.1303210042577;
	Tue, 19 Apr 2011 03:47:22 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.227.174.13 with HTTP; Tue, 19 Apr 2011 03:47:22 -0700 (PDT)
In-Reply-To: <201104191229.26974.milu@dat.pl>
References: <BANLkTikGsV7AMYG7GaJ5BN7yUKgugN+fBg@mail.gmail.com>
	<BANLkTimFRR2TE+H5Vop+TYms8mP4p4FPBg@mail.gmail.com>
	<201104171605.59340.bschmidt@freebsd.org>
	<201104191229.26974.milu@dat.pl>
Date: Tue, 19 Apr 2011 18:47:22 +0800
X-Google-Sender-Auth: cgolPZOCapyxThsNxSZTEv1NRWU
Message-ID: <BANLkTikKTZU1m3r+L2fyF7GMgDWBR+ruOA@mail.gmail.com>
From: Adrian Chadd <adrian@freebsd.org>
To: Maciej Milewski <milu@dat.pl>
Content-Type: text/plain; charset=ISO-8859-1
X-Content-Filtered-By: Mailman/MimeDel 2.1.5
Cc: freebsd-wireless@freebsd.org
Subject: Re: RFC: supporting multiple hostap instances in /etc/rc.conf
X-BeenThere: freebsd-wireless@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussions of 802.11 stack,
	tools device driver development." <freebsd-wireless.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-wireless>
List-Post: <mailto:freebsd-wireless@freebsd.org>
List-Help: <mailto:freebsd-wireless-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-wireless>, 
	<mailto:freebsd-wireless-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 19 Apr 2011 10:47:25 -0000

Why'd you remove the flags parameter and hard-code them?

2011/4/19 Maciej Milewski <milu@dat.pl>


> One simpler thing for quick running multiple instaces is giving multiple
> configs to the hostapd. Hostapd supports it from around 2005. This would
> run
> one instance of hostapd listening on all interfaces given in config files.
>
> Manual way:
> /usr/sbin/hostapd -P /var/run/hostapd.pid -B /etc/hostapd.conf
> /etc/hostapd2.conf /etc/hostapd3.conf
>
> Attached patch doesn't change default behaviour and adding multiple configs
> into rc.conf:
> hostapd_conf="/etc/hostapd.conf /etc/hostapd2.conf /etc/hostapd3.conf"
> makes it work with more interfaces.
>

Other than that, I think that's ok, but it just feels dirty for some reason.
Perhaps instead, allow the whole command line to be overridden, pid file, -B
and all?


Adrian