From owner-freebsd-haskell@freebsd.org Sun Nov 10 19:55:20 2019 Return-Path: Delivered-To: freebsd-haskell@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id EAD5B1BE710; Sun, 10 Nov 2019 19:55:20 +0000 (UTC) (envelope-from ietf-dane@dukhovni.org) Received: from straasha.imrryr.org (straasha.imrryr.org [100.2.39.101]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 47B4Vc3nNCz4KNY; Sun, 10 Nov 2019 19:55:20 +0000 (UTC) (envelope-from ietf-dane@dukhovni.org) Received: by straasha.imrryr.org (Postfix, from userid 1001) id 6156C329D31; Sun, 10 Nov 2019 14:55:19 -0500 (EST) Date: Sun, 10 Nov 2019 14:55:19 -0500 From: Viktor Dukhovni To: freebsd-haskell@freebsd.org, haskell@freebsd.org Subject: Re: FYI: Opened GHC PRs to add missing include of sys/types.h Message-ID: <20191110195519.GQ34850@straasha.imrryr.org> Reply-To: haskell@freebsd.org References: <20191110192729.GP34850@straasha.imrryr.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-Rspamd-Queue-Id: 47B4Vc3nNCz4KNY X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of ietf-dane@dukhovni.org designates 100.2.39.101 as permitted sender) smtp.mailfrom=ietf-dane@dukhovni.org X-Spamd-Result: default: False [-3.74 / 15.00]; ARC_NA(0.00)[]; HAS_REPLYTO(0.00)[haskell@freebsd.org]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; FROM_HAS_DN(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:100.2.39.101:c]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; TO_DN_NONE(0.00)[]; DMARC_NA(0.00)[dukhovni.org]; REPLYTO_DOM_NEQ_FROM_DOM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; RCVD_IN_DNSWL_MED(-0.20)[101.39.2.100.list.dnswl.org : 127.0.6.2]; RCPT_COUNT_TWO(0.00)[2]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:701, ipnet:100.2.0.0/16, country:US]; IP_SCORE(-1.24)[ip: (-4.68), ipnet: 100.2.0.0/16(-2.34), asn: 701(0.89), country: US(-0.05)] X-BeenThere: freebsd-haskell@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FreeBSD-specific Haskell issues and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 10 Nov 2019 19:55:21 -0000 On Sun, Nov 10, 2019 at 11:39:09PM +0400, Gleb Popov wrote: > > Once > > > > https://gitlab.haskell.org/ghc/ghc/merge_requests/2132 > > https://gitlab.haskell.org/ghc/ghc/merge_requests/2133 > > https://gitlab.haskell.org/ghc/ghc/merge_requests/2134 > > > > are merged, there will no longer be a need to apply a patch to > > libraries/base/dist-install/build/System/Environment/ExecutablePath.hsc > > to create "bindists" or any future ports for GHC 8.8.2 and beyond. > > Great, thanks for submitting this upstream. While at it, maybe you'll be > interested in upstreaming https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=241849 ? In fact I'm already looking at it, indeed this is what got me energized enough to submit the sys/time.h fixes upstream, but I first want to test the proposed fix a bit more. At a minimum, the condition for enabling the pthread codepath likely needs to be: #if defined(freebsd_HOST_OS) && defined(THREADED_RTS) rather than just: #if defined(freebsd_HOST_OS) which mimmics the Linux variant: #if defined(linux_HOST_OS) && defined(THREADED_RTS) && HAVE_SYS_TIMERFD_H #define USE_PTHREAD_FOR_ITIMER #endif -- Viktor.