From owner-freebsd-current  Wed Aug 30  9:43: 1 2000
Delivered-To: freebsd-current@freebsd.org
Received: from critter.freebsd.dk (fw2.aub.dk [195.24.1.195])
	by hub.freebsd.org (Postfix) with ESMTP id 371CA37B423
	for <current@freebsd.org>; Wed, 30 Aug 2000 09:42:55 -0700 (PDT)
Received: from critter (localhost [127.0.0.1])
	by critter.freebsd.dk (8.11.0/8.9.3) with ESMTP id e7UGgXN04910;
	Wed, 30 Aug 2000 18:42:33 +0200 (CEST)
	(envelope-from phk@critter.freebsd.dk)
To: Sheldon Hearn <sheldonh@uunet.co.za>
Cc: current@freebsd.org
Subject: Re: recent change to conf.h breaks xosview port 
In-Reply-To: Your message of "Wed, 30 Aug 2000 16:54:51 +0200."
             <67668.967647291@axl.fw.uunet.co.za> 
Date: Wed, 30 Aug 2000 18:42:33 +0200
Message-ID: <4908.967653753@critter>
From: Poul-Henning Kamp <phk@critter.freebsd.dk>
Sender: owner-freebsd-current@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG


<sys/conf.h> should not be included from userland, and if it is
a proper interface should be designed and used instead.

Poul-Henning

In message <67668.967647291@axl.fw.uunet.co.za>, Sheldon Hearn writes:
>
>Hi Poul-Henning,
>
>As of rev 1.116 of sys/sys/conf.h, the xosview port no longer builds.
>Your delta added 3 struct timespec members to struct specinfo.
>
>The affected xosview file includes the following headers files in
>order:
>
>#include <sys/param.h>
>#include <sys/conf.h>
>
>[...]
>
>The breakage looks like this:
>
>In file included from swapinternal.cc:67:
>/usr/include/sys/conf.h:59: field `si_atime' has incomplete type
>/usr/include/sys/conf.h:60: field `si_ctime' has incomplete type
>/usr/include/sys/conf.h:61: field `si_mtime' has incomplete type
>
>Including <sys/time.h> between the inclusion of <sys/param.h> and
><sys/conf.h> corrects the problem.
>
>Was this use of <sys/conf.h> always broken and only now problematic, or
>is there a new problem in <sys/conf.h>?
>
>To me, it looks like <sys/conf.h> should pull <sys/time.h> in for
>itself, although I understand that pollution comes along with that.
>
>Ciao,
>Sheldo.
>

--
Poul-Henning Kamp       | UNIX since Zilog Zeus 3.20
phk@FreeBSD.ORG         | TCP/IP since RFC 956
FreeBSD coreteam member | BSD since 4.3-tahoe    
Never attribute to malice what can adequately be explained by incompetence.


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-current" in the body of the message