From owner-freebsd-current Mon Apr 3 23:25:25 2000 Delivered-To: freebsd-current@freebsd.org Received: from overcee.netplex.com.au (peter1.yahoo.com [208.48.107.4]) by hub.freebsd.org (Postfix) with ESMTP id AF6FA37BF8B for ; Mon, 3 Apr 2000 23:25:06 -0700 (PDT) (envelope-from peter@netplex.com.au) Received: from netplex.com.au (localhost [127.0.0.1]) by overcee.netplex.com.au (Postfix) with ESMTP id 0BE021CD7; Mon, 3 Apr 2000 23:25:05 -0700 (PDT) (envelope-from peter@netplex.com.au) X-Mailer: exmh version 2.1.1 10/15/1999 To: Gary Jennejohn Cc: Bruce Evans , freebsd-current@FreeBSD.ORG Subject: Re: MLEN and crashes In-Reply-To: Message from Gary Jennejohn of "Mon, 03 Apr 2000 21:32:51 +0200." <200004031932.VAA23846@peedub.muc.de> Date: Mon, 03 Apr 2000 23:25:05 -0700 From: Peter Wemm Message-Id: <20000404062505.0BE021CD7@overcee.netplex.com.au> Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Gary Jennejohn wrote: > Bruce Evans writes: > >On Mon, 3 Apr 2000, Gary Jennejohn wrote: > > > >> Bruce Evans writes: > >> >On Sun, 2 Apr 2000, Gary Jennejohn wrote: > >> >> I think we should nuke csu_hdr since it's not used anywhere. Is that > >> >> what you really mean ? > >> > > >> >Yes. I'm trying the following patch. Only tested at compile time. > >> > > >> [patch snipped] > >> > >> Thank you, Bruce ! This is pretty much the same patch I tested. > >> > >> So, should I commit it ? > > > >If you have tested it :-). > > > > I'm running with the change right now. No problems. I would prefer that we did this: #define MAX_LEN (min(128, MLEN)) or something like that. This should stop Bad Things happening if somebody recompiles with MLEN set specifically to 128 (and is an ideal MFC candidate for 4.x for when people set MLEN to 256 over there). Cheers, -Peter -- Peter Wemm - peter@FreeBSD.org; peter@yahoo-inc.com; peter@netplex.com.au "All of this is for nothing if we don't go to the stars" - JMS/B5 To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message