From owner-freebsd-ports Thu Aug 12 7:10:33 1999 Delivered-To: freebsd-ports@freebsd.org Received: from plab.ku.dk (plab.ku.dk [130.225.105.65]) by hub.freebsd.org (Postfix) with ESMTP id 9DB1F1573B for ; Thu, 12 Aug 1999 07:10:23 -0700 (PDT) (envelope-from tobez@plab.ku.dk) Received: from lion.plab.ku.dk (lion.plab.ku.dk [130.225.105.49]) by plab.ku.dk (8.9.1/8.9.1) with ESMTP id QAA14138; Thu, 12 Aug 1999 16:07:54 +0200 (CEST) Received: (from tobez@localhost) by lion.plab.ku.dk (8.9.3/8.9.3) id QAA58654; Thu, 12 Aug 1999 16:05:01 +0200 (CEST) (envelope-from tobez) Date: Thu, 12 Aug 1999 16:05:01 +0200 From: Anton Berezin To: Tim Vanderhoek Cc: Bill Fumerola , freebsd-ports@FreeBSD.ORG Subject: Re: ports/13030: Many ports use ``chown'' rather than ``/usr/sbin/chown'' in their Makefiles Message-ID: <19990812160501.B57548@lion.plab.ku.dk> References: <19990809083649.B97354@mad> <19990812125750.B56987@lion.plab.ku.dk> <19990812093835.A44972@mad> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.4i In-Reply-To: <19990812093835.A44972@mad>; from Tim Vanderhoek on Thu, Aug 12, 1999 at 09:38:35AM -0400 Sender: owner-freebsd-ports@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org On Thu, Aug 12, 1999 at 09:38:35AM -0400, Tim Vanderhoek wrote: > > # skip clever CHOWN assignments - they are unnecessary > > next if m%^\s*CHOWN\s*\??=\s*(?:/usr/sbin/)?chown\s*$%; > > The script should probably bleat if it sees this. I don't think so. There are some ports which do that, and it *is* safe to remove the line. Or leave it as it is, alternatively - in most cases it is just CHOWN?=... Anyway, it is very easy to catch those - a single ``- line'' in unidiff is always alarming. :-) > > # change all /usr/sbin/chown for ${CHOWN} > > s%/usr/sbin/chown%\${CHOWN}%g; > > Better add \s+ to the start of that, just to be safe. Shouldn't make No! Consider @/usr/sbin/chown - there are plenty of these. > a difference, but consider linux_base, which does somethign like > ${PREFIX}/sbin/ldconfig. Such an instance should be left hardcoded. Probably just [^}] then? Cheers, -- Anton Berezin The Protein Laboratory, University of Copenhagen To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-ports" in the body of the message